Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Document the .at() proposal #307

Closed
chrisdavidmills opened this issue Dec 16, 2020 · 9 comments
Closed

[JS] Document the .at() proposal #307

chrisdavidmills opened this issue Dec 16, 2020 · 9 comments
Assignees
Labels
Content:JS JavaScript docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@chrisdavidmills
Copy link
Contributor

chrisdavidmills commented Dec 16, 2020

Acceptance criteria

    • The listed features are documented sufficiently on MDN
    • BCD is updated
    • Interactive example and data repos are updated if appropriate
    • The content has been reviewed as needed

Features to document

  1. .at(). From some simple testing, it looks like this is supported in Chrome Canary (89) and Firefox Nightly (85), but not release versions yet (see https://bugzilla.mozilla.org/show_bug.cgi?id=1681371, for example). I still think it is worth documenting; I reckon we need pages for:
  • String.prototype.at()
  • Array.prototype.at()
  • TypedArray.prototype.at()
  • Anything else?

Related Gecko bugs

For folks helping with Firefox-related documentation features — make sure above AC have been done, but also:

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release
@Rumyra Rumyra self-assigned this Jan 5, 2021
@Rumyra
Copy link
Collaborator

Rumyra commented Jan 11, 2021

@Rumyra
Copy link
Collaborator

Rumyra commented Jan 12, 2021

This PR isn't passing test and I'm not sure why 🤔

  • New docs
    • array
    • string
    • typed array
  • Updating existing object pages

For above draft PR is here #1216

  • BCD

I've added a PR here mdn/browser-compat-data#8721 however I used the proposal url as there is no spec url at this time... tests have not passed because of this and am unsure how to proceed

I'll do these once above are done/resolved

  • @@unscopables
  • Experimental features page

@Rumyra
Copy link
Collaborator

Rumyra commented Jan 20, 2021

Added note to experimental features #1525

@Rumyra
Copy link
Collaborator

Rumyra commented Jan 20, 2021

Added to @@unscopables #1526

@Rumyra
Copy link
Collaborator

Rumyra commented Jan 20, 2021

content PR #1216

@Rumyra
Copy link
Collaborator

Rumyra commented Jan 20, 2021

Apart from review of the content and dev-doc-complete flag, my todo lists are done for this @chrisdavidmills

@chrisdavidmills
Copy link
Contributor Author

Yay, set to dev-doc-complete. I'll ask Florian about what to do for the spec thing.

@Rumyra
Copy link
Collaborator

Rumyra commented Jan 25, 2021

I believe this is done \o/ everything should be merged... I'm moving it 🆒

@chrisdavidmills
Copy link
Contributor Author

Woo hoo!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 85 labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:JS JavaScript docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
None yet
Development

No branches or pull requests

3 participants