-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing (standard track) attributes for HTMLInputElement API #7647
Add missing (standard track) attributes for HTMLInputElement API #7647
Conversation
This PR is a part of a project to add missing interfaces and interface features to BCD that are from a spec in Editor's Draft or more and is supported in at least one browser. This particular PR adds missing features, populating the results using data from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v1.1.6), for the HTMLInputElement API. Spec: https://html.spec.whatwg.org/multipage/input.html#htmlinputelement IDL: https://github.com/w3c/webref/blob/master/ed/idl/html.idl
Note: the diff looks really weird on this PR, as if features are removed and/or renamed. No features are being removed in this PR. |
@vinyldarkscratch are updates to input.json also needed? |
Not |
OK, let's leave this issue as just updating |
"version_added": "5.5" | ||
"version_added": "10", | ||
"partial_implementation": true, | ||
"notes": "This property is read-only." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and other notes aren't being added/removed in this PR, it's just entries that appear to be changed in the diff due to other entries being added. I reviewed the actual differences using #6862
Looks like this PR adds a duplicate |
I quickly merged #7751 which is a hotfix PR that resolves the duplicate entry! |
Thanks @vinyldarkscratch 👍 |
@Elchi3 thanks for spotting that! The CI did pass, but when merging a bunch of PRs in a row this kind of thing can happen. Sorry! |
No worries! Both of you rock for getting all this data in :) |
This PR is a part of a project to add missing interfaces and interface features to BCD that are from a spec in Editor's Draft or more and is supported in at least one browser. This particular PR adds missing features, populating the results using data from the mdn-bcd-collector project (v1.1.6), for the HTMLInputElement API.
Spec: https://html.spec.whatwg.org/multipage/input.html#htmlinputelement
IDL: https://github.com/w3c/webref/blob/master/ed/idl/html.idl