Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing (standard track) attributes for HTMLInputElement API #7647

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

queengooborg
Copy link
Collaborator

This PR is a part of a project to add missing interfaces and interface features to BCD that are from a spec in Editor's Draft or more and is supported in at least one browser. This particular PR adds missing features, populating the results using data from the mdn-bcd-collector project (v1.1.6), for the HTMLInputElement API.

Spec: https://html.spec.whatwg.org/multipage/input.html#htmlinputelement
IDL: https://github.com/w3c/webref/blob/master/ed/idl/html.idl

This PR is a part of a project to add missing interfaces and interface features to BCD that are from a spec in Editor's Draft or more and is supported in at least one browser.  This particular PR adds missing features, populating the results using data from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v1.1.6), for the HTMLInputElement API.

Spec: https://html.spec.whatwg.org/multipage/input.html#htmlinputelement
IDL: https://github.com/w3c/webref/blob/master/ed/idl/html.idl
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 11, 2020
@queengooborg
Copy link
Collaborator Author

Note: the diff looks really weird on this PR, as if features are removed and/or renamed. No features are being removed in this PR.

@foolip
Copy link
Collaborator

foolip commented Dec 11, 2020

@vinyldarkscratch are updates to input.json also needed?

@queengooborg
Copy link
Collaborator Author

Not input.json, but most likely the individual input types. I didn't want to include those updates in this PR since it's already a large diff, and do the updates in a follow-up. I could include it in this PR if preferred, however?

@foolip
Copy link
Collaborator

foolip commented Dec 14, 2020

OK, let's leave this issue as just updating HTMLInputElement APIs. Can you file an issue about what follow-up syncing might be needed?

"version_added": "5.5"
"version_added": "10",
"partial_implementation": true,
"notes": "This property is read-only."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and other notes aren't being added/removed in this PR, it's just entries that appear to be changed in the diff due to other entries being added. I reviewed the actual differences using #6862

@foolip foolip merged commit 97a5f9f into mdn:master Dec 14, 2020
@queengooborg queengooborg deleted the api/HTMLInputElement-attributes branch December 14, 2020 11:03
@Elchi3
Copy link
Member

Elchi3 commented Dec 14, 2020

Looks like this PR adds a duplicate width entry and breaks the BCD build.

@queengooborg
Copy link
Collaborator Author

I quickly merged #7751 which is a hotfix PR that resolves the duplicate entry!

@Elchi3
Copy link
Member

Elchi3 commented Dec 14, 2020

Thanks @vinyldarkscratch 👍

@foolip
Copy link
Collaborator

foolip commented Dec 14, 2020

@Elchi3 thanks for spotting that! The CI did pass, but when merging a bunch of PRs in a row this kind of thing can happen. Sorry!

@Elchi3
Copy link
Member

Elchi3 commented Dec 14, 2020

No worries! Both of you rock for getting all this data in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants