Add missing features for HTMLInputElement #7592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
|
This PR is huge, and will also require checking that reflected IDL attributes have their content attribute data updated. @vinyldarkscratch how about splitting this into smaller pieces, where the diff of each piece becomes more managable? |
foolip
reviewed
Dec 11, 2020
| @@ -95,33 +94,32 @@ | |||
| } | |||
| } | |||
| }, | |||
| "autofocus": { | |||
| "align": { | |||
There was a problem hiding this comment.
align is listed in https://html.spec.whatwg.org/multipage/obsolete.html#HTMLInputElement-partial and should be deprecated. (But I can't make suggestions in that part of the diff.)
| "experimental": false, | ||
| "standard_track": true | ||
| "standard_track": true, | ||
| "deprecated": false |
There was a problem hiding this comment.
Suggested change
| "deprecated": false | |
| "deprecated": true |
https://html.spec.whatwg.org/multipage/obsolete.html#HTMLInputElement-partial
| @@ -191,47 +188,44 @@ | |||
| } | |||
| } | |||
| }, | |||
| "files": { | |||
| "autocapitalize": { | |||
There was a problem hiding this comment.
autocapitalize shouldn't be added: #7519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of a project to add missing interfaces and interface features to BCD that are from a spec in Editor's Draft or more and is supported in at least one browser. This particular PR adds missing features, populating the results using data from the mdn-bcd-collector project (v1.1.6), for the HTMLInputElement API.
Spec: https://html.spec.whatwg.org/multipage/semantics.html#htmlinputelement
IDL: https://github.com/w3c/webref/blob/master/ed/idl/html.idl
Notice: the diff looks pretty weird for this one due to the similarities in the results between all of the features. This PR doesn't modifying any existing features, however.