Clean up -webkit-background-clip data #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on mdn#4290, I found that `-webkit-background-clip` was added to WebKit at the same time as `appearance`: https://trac.webkit.org/changeset/13874/webkit Because this predates Chromium, I've set the `-webkit-background-clip` version on Chromium and derived browsers to their first releases.
This blog post on the WebKit post establishes that the `content-box` value was original to `-webkit-background-clip`, so I also updated the Chromiums accordingly: https://webkit.org/blog/164/background-clip-text/
This page establishes that Safari 4 first shipped the `text` value: https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariCSSRef/Articles/StandardCSSProperties.html I derived the iOS version from Safari 4's WebKit engine number. The discussion on this Chromium bug suggests that the `text` value started working in Chrome 3: https://crbug.com/8872
ddbeck
added
the
data:css
This was referenced Jun 12, 2019
Elchi3
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of issues with the background-clip data. It was kind of a mess. This also contributes to #3804 and #3805.
Update
-webkit-background-clipproperty data for WebKit and ChromiumWhile working on #4290, I found that
-webkit-background-clipwas added to WebKit at the same time asappearance: https://trac.webkit.org/changeset/13874/webkitBecause this predates Chromium, I've set the
-webkit-background-clipversionon Chromium and derived browsers to their first releases.
Since I was changing this data anyway, I also corrected the style of the notes, to refer to the browsers specifically (rather than WebKit generically).
Update
content-boxvalue data for ChromiumThis blog post on the WebKit post establishes that the
content-boxvalue was original to-webkit-background-clip, so I updated the Chromiums accordingly: https://webkit.org/blog/164/background-clip-text/Clean up
textvalue dataFirst, I cleaned up the version data itself:
textvalue: https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariCSSRef/Articles/StandardCSSProperties.htmltextvalue startedworking in Chrome 3: https://crbug.com/8872
Then I cleaned up the messy
prefixdata and notes. Mostly, I replacedprefixdata withpartial_implementationto catch that apparently some browsers only allowtextwith the-webkit-prefix on the property itself (not the value), or I removed the data where it didn't appear to be applicable. Since I was changing the notes, I also corrected for style, splitting the distinct notes into arrays.