Update -webkit-appearance button and textfield values #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://trac.webkit.org/changeset/13874 both values were included when -webkit-appearance first shipped. I set the Safaris to the release where `-webkit-appearance` shipped. I set Chromium-derived browsers' values to the first release that they shipped (as the feature predates Chromium entirely).
ddbeck
added
the
data:css
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jun 12, 2019
While working on mdn#4290, I found that `-webkit-background-clip` was added to WebKit at the same time as `appearance`: https://trac.webkit.org/changeset/13874/webkit Because this predates Chromium, I've set the `-webkit-background-clip` version on Chromium and derived browsers to their first releases.
Elchi3
pushed a commit
that referenced
this pull request
Jun 13, 2019
* Update `-webkit-background-clip` While working on #4290, I found that `-webkit-background-clip` was added to WebKit at the same time as `appearance`: https://trac.webkit.org/changeset/13874/webkit Because this predates Chromium, I've set the `-webkit-background-clip` version on Chromium and derived browsers to their first releases. * Update `-webkit-background-clip: content-box` This blog post on the WebKit post establishes that the `content-box` value was original to `-webkit-background-clip`, so I also updated the Chromiums accordingly: https://webkit.org/blog/164/background-clip-text/ * Update `-webkit-background-clip: text` This page establishes that Safari 4 first shipped the `text` value: https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariCSSRef/Articles/StandardCSSProperties.html I derived the iOS version from Safari 4's WebKit engine number. The discussion on this Chromium bug suggests that the `text` value started working in Chrome 3: https://crbug.com/8872 * Use correct browser names in background-clip notes * Fix notes/prefix data for "background-clip: text"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://trac.webkit.org/changeset/13874 both values were included when
-webkit-appearancefirst shipped in WebKit.I set the Safaris to the release where
-webkit-appearanceshipped. I set Chromium-derived browsers' values to the first release that they shipped (as the feature predates Chromium entirely).This contributes to #3804.