Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version numbers WebView for Android KitKat (4.4.x) #3884

Merged
merged 9 commits into from
Apr 15, 2019

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Apr 14, 2019

I found a Chrome Developer article that may disprove our idea that "37" is the first WebView based upon Chromium. It seems to refer to Android KitKat (4.4) as having WebView v30, which is based upon Chromium 30, and 4.4.3 as WebView v33. It also mentions WebView v36, which was available as a beta, but @jpmedley had said that it shouldn't be included. Android Lolipop (5.0) is probably when v37 came out and it became an APK separate from the OS, allowing updates in unison with Chrome.

@jpmedley Hoping you can shed some light on this one!

@queengooborg queengooborg added the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label Apr 14, 2019
@Elchi3
Copy link
Member

Elchi3 commented Apr 15, 2019

disprove our idea that "37" is the first WebView based upon Chromium

I think we never thought about 37 as the first version here.

Android Lolipop (5.0) is probably when v37 came out and it became an APK separate from the OS,

This is the main point here. The decoupling. From that point on, web devs don't need to care about the Android version anymore, but about the WebView version which end-users can update separately from then.

For more info, see also the original PR that added browser data for WebView Android and in particular my comment: #2690 (comment)

@queengooborg
Copy link
Contributor Author

queengooborg commented Apr 15, 2019

I know that it was mentioned several times that any Chrome versions earlier than 37 should be bumped up to 37 in WebView, though from what I can tell, we should be bumping them up to Android 4.4 (30) and 4.4.3 (33).

Based upon what you’re saying though, we should probably leave them as their original Android version numbers. Lemme make those changes real quick!

@jpmedley
Copy link
Contributor

Some of the confusion around this is my fault. I've said different things as my understanding has changed. Part of the problem is that when I've asked fellow googlers about this, I've gotten assertions based on memory instead of actual evidence, which is why I didn't know about the article you just found.

So:

  • 37 is when parity with Chrome begins.
  • Before 37 use Android numbers and add engine versions as soon as that becomes available.

What are the plans, if any, to render engine version numbers in compat tables?

@queengooborg
Copy link
Contributor Author

The plans of adding the engine version numbers are in #3877 and are underway. I'm not sure about the rendering part, but I'd imagine that we're planning it!

Thanks for your review, @jpmedley. 💜

@queengooborg queengooborg merged commit 1dd93d1 into mdn:master Apr 15, 2019
@queengooborg queengooborg deleted the browsers/webview branch April 15, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:browsers Data about browsers (versions, release dates, etc). This data is used for validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants