-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webview_android browser data #2690
Conversation
No because you've only listed the version of Chrome that Android shipped with. After the phone is activated, Chrome and webview auto-update with every Chrome release. |
Not sure I understand how this is contrary to what this PR does. This PR adds valid WebView versions. WebView used to be part of the Android OS and so we're referring to the Android version for that period (caniuse does this as well btw). Some WebViews were already based on Chrome. I know of two here. Still we're going with the Android versions, as these are more commonly referred to when the WebView was not decoupled from Android OS. So, that leaves us with these:
Then in Android 5, WebView was decoupled from Android OS and now auto updates with every Chrome release. So, instead of adding Android 5 as a valid version, we refer to the first version of Chrome that was available on Android 5 (this is 37). And now that we're decoupled from Android, we can start using Chrome versions until the current one. So, we end up with all of these:
Please see the diff of this PR for all versions added. |
Sorry, I have a tendency to go on autopilot regarding the webview issue. It's the result of too many discussions with people who think webview is still tied to Android. |
There are also a few early android versions that already included a web browser. So, maybe we should add these as well. https://en.wikipedia.org/wiki/Android_version_history#Version_history_by_API_level
"1" would then be a valid first version which might make sense in a lot of cases. See #2717 Opinions? |
406ce57
to
0ea67d6
Compare
Updated to add early android versions. (also edited my comment above) |
0ea67d6
to
a6b1cd5
Compare
a6b1cd5
to
c8fb937
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in browsers.json look fine, except one blog post seems to be missing again.
As for the changes in the data, from the diffs it looks like you've mostly done this:
- whole numbers 4-28 inclusive ->
true
- 2.1 ->
2
- 2.6 ->
3
- 4.3, 29, 30 ->
4.4
- 4.4.4, 31, 32, 33->
4.4.3
- 34, 35, 36 ->
37
- 5.1 ->
38
But there are a few instances that don't follow this rule:
- in css/properties/display.json, 32->
4
- in css/properties/orphans.json, 25 ->
4.4
- in css/selectors/scope.json, 27 ->
4.4
- in html/elements/template.json, 27 ->
4.4
- in html/elements/track.json, 25->
4.4
Without really understanding the reasoning behind the mappings, it's hard for me to tell if these are what you intended or not :).
browsers/webview_android.json
Outdated
}, | ||
"48": { | ||
"release_date": "2016-01-26", | ||
"release_notes": "https://chromereleases.googleblog.com/2016/01/chrome-for-android-update.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link doesn't work - it looks like there wasn't a blog post for this release?
c8fb937
to
003dead
Compare
Nice catches, @wbamberg ! 👍 Updated the instances that didn't follow these rules and removed the non-existent release notes. |
Your changes look good to me! There were some merge conflicts in Event.json, which I've tried to fix. But now there's also a linting error, where |
c73ca86
to
02016f0
Compare
I've rebased again. I think we're ready to merge now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Elchi3 !
The fixes the last item on #591: Add release data (allowed versions) for
webview_android
and validate our compat data with it.Some notes here:
@jpmedley can you have a look here? Does this allow-list for
webview_android
versions make sense to you?