-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing __compat+mdn_url to top-level extension namespaces #22338
Conversation
652856e
to
1998c6f
Compare
CI is failing because the contextualIdentities entry depends on the fixup from #22337. I'll rebase this PR when the other gets merged. And after adding |
Another note: after adding the top-level compat info, the linter complained about incorrect entries in between. E.g. Safari liststs devtools API methods but missed entries at the individual subnamespaces. I fixed these too. In tabs.json, executeScript was flagged as supported in 43. I bumped it to 45 for consistency with the others. I think that the support status is based on when the schema landed, which is in 45: https://hg.mozilla.org/mozilla-central/rev/7b0f6544f9b6b18c87e0bcacc215726a5804f2f2 |
1998c6f
to
9e96887
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
9e96887
to
79dc5ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rob--W I've done a spot check for URLs and version information, everything looks OK, let me know if I should be doing comprehensive check.
Let's merge it. |
Summary
Add
__compat and missing
mdn_url` to every extension API namespace that lacks such an entry at the API namespace level. Also fixed up some individual entries.To populate the
__compat
objects, I copied and pasted an existing entry from another API entry within the file (ideally the oldest supported entry where possible), then modified the support state. I used my knowledge of Chrome and Firefox extension API support to resolve non-trivial cases. E.g.search.search
andsearch.query
have different support ranges in Firefox and Chrome, but the namespace they belong to (search) is set to the earliest version that supports either method.The contextualIdentities entry has a note on Android compat, for consistency with the other entries as added in #22337, generated by #22337 (comment)
Test results and supporting details
Related issues