Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect webextension compat info #22337

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Feb 29, 2024

Summary

Fix incorrect BCD support info, and added impl_url to some entries that have a bug tracking their implementation.

Test results and supporting details

alarms: drop confusing compat info about past timers. The version_added/version_removed ranges are hard to interpret. The affected versions are ancient and the use of past timers is very unusual. Hence, the simplest way to resolve the ambiguity is to drop the note. Ref: https://bugzilla.mozilla.org/show_bug.cgi?id=1478694

clipboard API disabled in Firefox for Android:
https://searchfox.org/mozilla-central/rev/0e7394a77cdbe1df5e04a1d4171d6da67b57fa17/toolkit/components/extensions/parent/ext-clipboard.js#25-31

contextualIdentities not functional in Firefox for Android: https://bugzilla.mozilla.org/show_bug.cgi?id=1638878

cookies: partitionKey supported in Chrome 119+: crbug.com/1225444 https://chromium.googlesource.com/chromium/src/+/45052d18b0f8dd0eb1a7492dc92acb8ba96aff64

dns: API restricted to Chrome dev
https://chromium.googlesource.com/chromium/src/+/603f4f94bc1d9bc363483bca56d31db492912d1a/extensions/common/api/_permission_features.json#231 "This API is only available in Chrome Dev. There are no foreseeable
plans to move this API from the dev channel into Chrome stable."
https://developer.chrome.com/docs/extensions/reference/api/dns#availability

events: although it is more of an abstract interface, the methods are supported in Firefox, e.g. as seen at:
https://searchfox.org/mozilla-central/rev/0e7394a77cdbe1df5e04a1d4171d6da67b57fa17/toolkit/components/extensions/schemas/events.json#45

tabs: tabs.detectLanguage supported in Firefox for Android 118+: https://bugzilla.mozilla.org/show_bug.cgi?id=1817779

manifest/commands: _execute_browser_action introduced in: https://bugzilla.mozilla.org/show_bug.cgi?id=1246034

manifest/commands: _execute_page_action introduced in: https://bugzilla.mozilla.org/show_bug.cgi?id=1246035

manifest/background: Safari non-persistent background support mentioned in https://developer.apple.com/documentation/safari-release-notes/safari-14_1-release-notes

manifest/content_scripts: match_origin_as_fallback added in: https://chromium.googlesource.com/chromium/src/+/53396b76e9375 https://chromium.googlesource.com/chromium/src/+/53396b76e9375/chrome/VERSION

manifest/content_security_policy: isolated_world never shipped anywhere: https://bugzilla.mozilla.org/show_bug.cgi?id=1594232#c5

Related issues

N/A

@github-actions github-actions bot added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Feb 29, 2024
@Rob--W
Copy link
Member Author

Rob--W commented Feb 29, 2024

Note: most of it was manually curated.

The contextualIdentities entry was bulk-edited automatically with the following snippet:

node -e 'fs=require("node:fs");d=fs.readFileSync("api/contextualIdentities.json","utf-8");d=JSON.parse(d);function r(o){for (let i in o) {if(i=="firefox_android"){o[i]={version_added:false,impl_url:"https://bugzil.la/1638878",notes:"contextualIdentities is defined but not functional in Firefox for Android."};}else if(typeof o[i]=="object"&&o[i])r(o[i])}};r(d);fs.writeFileSync("api/contextualIdentities.json", JSON.stringify(d, null, 2) + "\n" )'

Copy link
Collaborator

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rob--W

  • let me know if you need me to merge this once you've reviewed my suggestions
  • should I cross-check the additions/removals against the documentation?

webextensions/api/contextualIdentities.json Outdated Show resolved Hide resolved
webextensions/api/contextualIdentities.json Outdated Show resolved Hide resolved
webextensions/api/contextualIdentities.json Outdated Show resolved Hide resolved
webextensions/api/contextualIdentities.json Outdated Show resolved Hide resolved
webextensions/api/contextualIdentities.json Outdated Show resolved Hide resolved
webextensions/api/contextualIdentities.json Outdated Show resolved Hide resolved
webextensions/api/contextualIdentities.json Outdated Show resolved Hide resolved
webextensions/api/contextualIdentities.json Outdated Show resolved Hide resolved
webextensions/api/contextualIdentities.json Outdated Show resolved Hide resolved
"version_added": false
"version_added": false,
"impl_url": "https://bugzil.la/1725981",
"notes": "The object is defined but any attempt to read or modify the setting throws."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"notes": "The object is defined but any attempt to read or modify the setting throws."
"notes": "The object is defined but any attempt to read or modify the setting throws an exception."

@Rob--W Rob--W force-pushed the webext-many-compat-fixups branch from 95bc6c9 to 41d942a Compare March 3, 2024 16:01
Fix incorrect BCD support info, and added impl_url to some entries that
have a bug tracking their implementation.

alarms: drop confusing compat info about past timers. The
version_added/version_removed ranges are hard to interpret. The affected
versions are ancient and the use of past timers is very unusual. Hence,
the simplest way to resolve the ambiguity is to drop the note. Ref:
https://bugzilla.mozilla.org/show_bug.cgi?id=1478694

clipboard API disabled in Firefox for Android:
https://searchfox.org/mozilla-central/rev/0e7394a77cdbe1df5e04a1d4171d6da67b57fa17/toolkit/components/extensions/parent/ext-clipboard.js#25-31

contextualIdentities not functional in Firefox for Android:
https://bugzilla.mozilla.org/show_bug.cgi?id=1638878

cookies: partitionKey supported in Chrome 119+: crbug.com/1225444
https://chromium.googlesource.com/chromium/src/+/45052d18b0f8dd0eb1a7492dc92acb8ba96aff64

dns: API restricted to Chrome dev
https://chromium.googlesource.com/chromium/src/+/603f4f94bc1d9bc363483bca56d31db492912d1a/extensions/common/api/_permission_features.json#231
"This API is only available in Chrome Dev. There are no foreseeable
 plans to move this API from the dev channel into Chrome stable."
https://developer.chrome.com/docs/extensions/reference/api/dns#availability

events: although it is more of an abstract interface, the methods are
supported in Firefox, e.g. as seen at:
https://searchfox.org/mozilla-central/rev/0e7394a77cdbe1df5e04a1d4171d6da67b57fa17/toolkit/components/extensions/schemas/events.json#45

tabs: tabs.detectLanguage supported in Firefox for Android 118+:
https://bugzilla.mozilla.org/show_bug.cgi?id=1817779

manifest/commands: _execute_browser_action introduced in:
https://bugzilla.mozilla.org/show_bug.cgi?id=1246034

manifest/commands: _execute_page_action introduced in:
https://bugzilla.mozilla.org/show_bug.cgi?id=1246035

manifest/background: Safari non-persistent background support mentioned in
https://developer.apple.com/documentation/safari-release-notes/safari-14_1-release-notes

manifest/content_scripts: match_origin_as_fallback added in:
https://chromium.googlesource.com/chromium/src/+/53396b76e9375
https://chromium.googlesource.com/chromium/src/+/53396b76e9375/chrome/VERSION

manifest/content_security_policy: isolated_world never shipped anywhere:
https://bugzilla.mozilla.org/show_bug.cgi?id=1594232#c5
@Rob--W Rob--W force-pushed the webext-many-compat-fixups branch from 41d942a to f944682 Compare March 3, 2024 16:03
@Rob--W
Copy link
Member Author

Rob--W commented Mar 3, 2024

@Rob--W

* let me know if you need me to merge this once you've reviewed my suggestions

Thanks for the suggestions. To make sure that I don't miss any, I applied the suggested change (wrap contextualIdentities in <code>-tags in a scripted fashion, with a modification of the script I posted at #22337 (comment))

* should I cross-check the additions/removals against the documentation?

I've already done so, so it's not needed to check again.

@Rob--W
Copy link
Member Author

Rob--W commented Mar 3, 2024

I've rebased to the main branch, please merge if you don't see any more issues. Then I'll rebase #22338 to make CI green.

@rebloor rebloor merged commit 461fd5b into mdn:main Mar 3, 2024
6 checks passed
@rebloor
Copy link
Collaborator

rebloor commented Mar 3, 2024

@Rob--W done, let me know if you want me to take a look at #22338 when it's ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants