Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oculus Browser to browsers, and compatibility data for api/A* #12642

Closed
wants to merge 5 commits into from
Closed

Add Oculus Browser to browsers, and compatibility data for api/A* #12642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6df5f56
Add Oculus Browser to schemas, tests, templates; add version data
Sep 7, 2021
356b5ad
Add Oculus Browser compatibility data for api/A*
Sep 29, 2021
fbb8d28
Remove irrelevant note about per-tab AudioContext limits in Chrome 66.
Sep 30, 2021
c0a8b4f
Remove Oculus Browser versions which will not appear in API entries.
Oct 7, 2021
d5d846b
Make APIs which do not generate events "partial" in Oculus Browser.
Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/snippets.code-snippets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
" \"ie\": {",
" \"version_added\": null",
" },",
" \"oculus\": {",
" \"version_added\": null",
" },",
" \"opera\": {",
" \"version_added\": null",
" },",
Expand Down
12 changes: 12 additions & 0 deletions api/ANGLE_instanced_arrays.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
"ie": {
"version_added": "11"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "19"
},
Expand Down Expand Up @@ -71,6 +74,9 @@
"ie": {
"version_added": "11"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "19"
},
Expand Down Expand Up @@ -120,6 +126,9 @@
"ie": {
"version_added": "11"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "19"
},
Expand Down Expand Up @@ -169,6 +178,9 @@
"ie": {
"version_added": "11"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "19"
},
Expand Down
12 changes: 12 additions & 0 deletions api/AbortController.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
"nodejs": {
"version_added": "15.0.0"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "53"
},
Expand Down Expand Up @@ -98,6 +101,9 @@
"nodejs": {
"version_added": "15.0.0"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "53"
},
Expand Down Expand Up @@ -167,6 +173,9 @@
"nodejs": {
"version_added": "15.0.0"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "53"
},
Expand Down Expand Up @@ -236,6 +245,9 @@
"nodejs": {
"version_added": "15.0.0"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "53"
},
Expand Down
9 changes: 9 additions & 0 deletions api/AbortPaymentEvent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": false
},
"opera": {
"version_added": "57"
},
Expand Down Expand Up @@ -70,6 +73,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": false
},
"opera": {
"version_added": "57"
},
Expand Down Expand Up @@ -118,6 +124,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": false
},
"opera": {
"version_added": "57"
},
Expand Down
15 changes: 15 additions & 0 deletions api/AbortSignal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
"nodejs": {
"version_added": "15.0.0"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "53"
},
Expand Down Expand Up @@ -83,6 +86,9 @@
"nodejs": {
"version_added": false
},
"oculus": {
"version_added": "17.0"
},
"opera": {
"version_added": false
},
Expand Down Expand Up @@ -139,6 +145,9 @@
"nodejs": {
"version_added": "15.0.0"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "53"
},
Expand Down Expand Up @@ -194,6 +203,9 @@
"nodejs": {
"version_added": "15.0.0"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "53"
},
Expand Down Expand Up @@ -249,6 +261,9 @@
"nodejs": {
"version_added": "15.0.0"
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "53"
},
Expand Down
8 changes: 8 additions & 0 deletions api/AbsoluteOrientationSensor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "6.0",
"partial_implementation": true,
"notes": "<code>AbsoluteOrientationSensor</code> is defined but it never generates any readings."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're not there yet alphabetically, but I'd expect a note consistent with this to appear on the ancestor interface property and method too (i.e., the places where you'd actually try to get the readings).

},
"opera": {
"version_added": "54"
},
Expand Down Expand Up @@ -72,6 +77,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "6.0"
},
"opera": {
"version_added": "54"
},
Expand Down
18 changes: 18 additions & 0 deletions api/AbstractRange.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "16.0"
},
"opera": {
"version_added": "76"
},
Expand Down Expand Up @@ -83,6 +86,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "16.0"
},
"opera": {
"version_added": "76"
},
Expand Down Expand Up @@ -138,6 +144,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "16.0"
},
"opera": {
"version_added": "76"
},
Expand Down Expand Up @@ -193,6 +202,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "16.0"
},
"opera": {
"version_added": "76"
},
Expand Down Expand Up @@ -248,6 +260,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "16.0"
},
"opera": {
"version_added": "76"
},
Expand Down Expand Up @@ -303,6 +318,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "16.0"
},
"opera": {
"version_added": "76"
},
Expand Down
17 changes: 17 additions & 0 deletions api/Accelerometer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "6.0",
"partial_implementation": true,
"notes": "<code>Accelerometer</code> is defined but it never generates any readings."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a case where you'll probably want to show partial and a note on the members of the interface too. Otherwise, a reader can go to the page for Accelerometer.x on MDN and miss out on this information.

},
"opera": {
"version_added": "54"
},
Expand Down Expand Up @@ -72,6 +77,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "6.0"
},
"opera": {
"version_added": "54"
},
Expand Down Expand Up @@ -121,6 +129,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "6.0"
},
"opera": {
"version_added": "54"
},
Expand Down Expand Up @@ -170,6 +181,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "6.0"
},
"opera": {
"version_added": "54"
},
Expand Down Expand Up @@ -219,6 +233,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "6.0"
},
"opera": {
"version_added": "54"
},
Expand Down
20 changes: 20 additions & 0 deletions api/AmbientLightSensor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,18 @@
"ie": {
"version_added": false
},
"oculus": {
"flags": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it's not codified anywhere and ought to be, but it's conventional to order this: added, removed, partial, notes, flags (or near enough to that).

{
"type": "preference",
"name": "#enable-experimental-web-platform-features",
"value_to_set": "Enabled"
}
],
"version_added": "5.0",
"partial_implementation": true,
"notes": "<code>AmbientLightSensor</code> is defined but it never generates any readings."
Copy link
Contributor

@lukewarlow lukewarlow Sep 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would at a minimum mark as partially implemented. Same for any other sensors that are defined but don't work.

Though I think potentially while it's still flagged just leave it as version_added false. And then maybe once it's unflagged a decision could be made on how to represent it.

Potentially could set version_added false but leave the note. Not sure what's best, one of the maintainers will be better placed to make that decision.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say as a web developer if it straight up doesn't work and is still flagged the partial with flag is pretty useless information. Once it's unflagged and I can find the interface a note (+ optionally a partial implementation boolean) would be very useful to explain the odd behaviour.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think partial is the right call here. If the interface exists, then it'll complicate feature detection; showing version_added: false is going to tell a simple but misleading story instead.

},
"opera": {
"version_added": "43",
"flags": [
Expand Down Expand Up @@ -107,6 +119,9 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "5.0"
},
"opera": {
"version_added": "43"
},
Expand Down Expand Up @@ -158,6 +173,11 @@
"ie": {
"version_added": false
},
"oculus": {
"version_added": "5.0",
"partial_implementation": true,
"notes": "<code>illuminance</code> always returns <code>null</code>."
},
"opera": {
"version_added": "43",
"notes": "In Opera 66, this method stopped returning floats and returned integers to avoid fingerprinting."
Expand Down
Loading