Add Oculus Browser to browsers, and compatibility data for api/A* #12642

dominiccooney · 2021-09-29T12:53:54Z

Summary

This adds Oculus Browser to schema, browsers, templates and tests with compatibility data for everything in api/A*.

Test results and supporting details

npm run lint passes
https://developer.oculus.com/documentation/web/browser-release-notes/

Related issues

See #12303

api/AudioContext.json

lukewarlow · 2021-09-29T15:45:36Z

api/AudioTrack.json

@@ -64,6 +64,16 @@
          "ie": {
            "version_added": "10"
          },
+          "oculus": {
+            "flags": [


Does oculus browser support flags? And more specifically does it support this flag?

Yes, Oculus Browser supports flags. The URL is chrome://flags similar to Chrome. In general our flags are the Chrome ones, same names, plus a couple of Oculus Browser specific ones. Experimental Web Features specifically is a valid flag for Oculus Browser.

lukewarlow · 2021-09-29T15:47:05Z

browsers/oculus.json

+    "oculus": {
+      "accepts_flags": true,
+      "name": "Oculus Browser",
+      "pref_url": "chrome://flags",


Just double checking this is the correct URL?

Yep. For various reasons Oculus Browser uses the chrome: scheme for these surfaces; chrome://flags is right.

lukewarlow · 2021-09-29T15:47:38Z

browsers/oculus.json

+{
+  "browsers": {
+    "oculus": {
+      "accepts_flags": true,


Same as comment above, just wanna double check does the oculus browser support flags?

Yes! Oculus Browser supports flags by entering chrome://flags in the address bar. We don't navigate links to that URL for security reasons but entering it directly brings up a page to search and set flags similar to Chrome for Android.

dominiccooney · 2021-09-30T02:15:42Z

Thank you @lukewarlow for the feedback. I've fixed the note and added some replies inline. Please take another look.

dominiccooney · 2021-09-30T02:34:11Z

If I could bring particular attention to something, what do you think about the notes on AbsoluteOrientationSensor, Accelerometer and AmbientLightSensor? For a number of APIs (mostly sensors but some others, for example Geolocation, Web Share, etc.) Oculus Browser has an interface present, all the prototypes are right, etc. But the API is a dead end because we don't light up something about the API: Sensors never generate readings; sharing requests are always rejected; etc. (At the moment.)

Would it be best to say that is "partial" support so developers get an indication that something's up? That also looks a bit weird because every API surface is "present."

lukewarlow · 2021-09-30T10:48:00Z

api/AmbientLightSensor.json

+              }
+            ],
+            "version_added": "5.0",
+            "notes": "<code>AmbientLightSensor</code> is defined but it never generates any readings."


I would at a minimum mark as partially implemented. Same for any other sensors that are defined but don't work.

Though I think potentially while it's still flagged just leave it as version_added false. And then maybe once it's unflagged a decision could be made on how to represent it.

Potentially could set version_added false but leave the note. Not sure what's best, one of the maintainers will be better placed to make that decision.

I would say as a web developer if it straight up doesn't work and is still flagged the partial with flag is pretty useless information. Once it's unflagged and I can find the interface a note (+ optionally a partial implementation boolean) would be very useful to explain the odd behaviour.

I think partial is the right call here. If the interface exists, then it'll complicate feature detection; showing version_added: false is going to tell a simple but misleading story instead.

queengooborg · 2021-09-30T15:56:00Z

Hey @dominiccooney, this is looking great so far!

Question: are there any compatibility differences between Oculus browser versions with the same Blink version that we would track here in BCD? If not, we should consolidate the releases like we do for NodeJS and strip out any releases where we wouldn't add compatibility data.

dominiccooney · 2021-10-03T23:55:13Z

@queengooborg

Question: are there any compatibility differences between Oculus browser versions with the same Blink version that we would track here in BCD?

Yes. While the "closest" competitor is Chrome for Android, there are some features Oculus Browser doesn't support (Web Share, Web Payments, Notifications, many of the Sensor subtypes ...) Many have stubs which return rejected Promises/generate no callbacks/etc. And Oculus Browser supports some XR features that Chrome for Android does not (IIRC frame rate control, hands input, composited layers...)

queengooborg · 2021-10-04T00:07:05Z

@dominiccooney I'm not talking about differences between Chrome Android and Oculus Browser. What I mean is: you're adding entries for every version of the Oculus Browser in this PR, most of which have matching engine versions (Oculus 6.0 and 6.1 are powered by Blink 74). Are there any compatibility differences in between these versions, i.e. was there something BCD tracks that was introduced in Oculus 6.1 and wasn't in Oculus 6.0?

dominiccooney · 2021-10-06T02:42:27Z

@queengooborg

Are there any compatibility differences in between these versions, i.e. was there something BCD tracks that was introduced in Oculus 6.1 and wasn't in Oculus 6.0?

Ah, got it. No. This is one point I was keen for feedback on, should we even mention point releases which don't appear in changes like that?

In general point releases can have changes that BCD would track. For example 7.1 added WebXR gamepads and fixed problems with the OVR_multiview2 WebGL extension.

queengooborg · 2021-10-06T04:25:44Z

Thanks for the response! Our stance for minor releases for NodeJS has been to only include "significant" releases (i.e. releases with a change in compatibility) rather than every release, so I feel that we should do the same for Oculus Browser as well (and probably at some point consolidate Samsung Internet releases, but that's another issue), and add in the releases with a minor semver bump as needed. We don't have a guideline for this, admittedly.

dominiccooney · 2021-10-12T01:37:13Z

@lukewarlow, @queengooborg, @ddbeck I think this is ready for another round of feedback. Please take another look.

ddbeck

Thank you for putting this together, @dominiccooney! I've just started to dip into this, but I've got a few initial comments for you. Let me know if you have questions and I'll return to this as soon as I can.

ddbeck · 2021-10-26T15:19:36Z

browsers/oculus.json

+  "browsers": {
+    "oculus": {
+      "accepts_flags": true,
+      "name": "Oculus Browser",


nit: would you mind putting this key first? It's nice to have first thing, when referring to the file for version mappings, etc.

ddbeck · 2021-10-26T15:21:50Z

browsers/oculus.json

+      "name": "Oculus Browser",
+      "pref_url": "chrome://flags",
+      "releases": {
+        "5.0": {


Just to be clear: this means that "5.0" will end up being the first version represented in compat tables, etc. Is that OK? I figure this is preferable to researching older features, but I wanted to confirm it.

ddbeck · 2021-10-26T15:27:05Z

api/AbsoluteOrientationSensor.json

+          "oculus": {
+            "version_added": "6.0",
+            "partial_implementation": true,
+            "notes": "<code>AbsoluteOrientationSensor</code> is defined but it never generates any readings."


I know you're not there yet alphabetically, but I'd expect a note consistent with this to appear on the ancestor interface property and method too (i.e., the places where you'd actually try to get the readings).

ddbeck · 2021-10-26T15:28:41Z

api/Accelerometer.json

+          "oculus": {
+            "version_added": "6.0",
+            "partial_implementation": true,
+            "notes": "<code>Accelerometer</code> is defined but it never generates any readings."


This is a case where you'll probably want to show partial and a note on the members of the interface too. Otherwise, a reader can go to the page for Accelerometer.x on MDN and miss out on this information.

ddbeck · 2021-10-26T15:32:27Z

api/AmbientLightSensor.json

@@ -44,6 +44,18 @@
          "ie": {
            "version_added": false
          },
+          "oculus": {
+            "flags": [


nit: it's not codified anywhere and ought to be, but it's conventional to order this: added, removed, partial, notes, flags (or near enough to that).

ddbeck · 2021-10-26T15:32:31Z

api/AmbientLightSensor.json

+              }
+            ],
+            "version_added": "5.0",
+            "notes": "<code>AmbientLightSensor</code> is defined but it never generates any readings."


I think partial is the right call here. If the interface exists, then it'll complicate feature detection; showing version_added: false is going to tell a simple but misleading story instead.

Elchi3 · 2021-11-15T11:50:55Z

@dominiccooney ping :)

queengooborg · 2022-04-20T19:46:14Z

I've opened up #15923 to handle the addition of the browser data, cherry-picked from this PR!

dominiccooney · 2022-04-23T13:15:45Z

Sorry for the slow reply @queengooborg . My understanding is: People are working on this. But I'm not sure when they plan to update this PR so for now I will close this to reduce clutter. We can always review the feedback in the closed PR. Thanks for the feedback (@ddbeck too) and sorry for the spam keeping this open for so long.

dominiccooney requested a review from ddbeck as a code owner September 29, 2021 12:53

github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 29, 2021

lukewarlow reviewed Sep 29, 2021

View reviewed changes

dominiccooney force-pushed the oculus-browser-thru-a branch from d4ecdff to fa4380e Compare September 30, 2021 02:02

lukewarlow reviewed Sep 30, 2021

View reviewed changes

queengooborg added data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. bulk_update An update to a mass amount of data, or scripts/linters related to such changes labels Sep 30, 2021

Dominic Cooney added 4 commits October 7, 2021 11:15

Add Oculus Browser to schemas, tests, templates; add version data

6df5f56

Add Oculus Browser compatibility data for api/A*

356b5ad

Remove irrelevant note about per-tab AudioContext limits in Chrome 66.

fbb8d28

Remove Oculus Browser versions which will not appear in API entries.

c0a8b4f

dominiccooney force-pushed the oculus-browser-thru-a branch from fa4380e to c0a8b4f Compare October 7, 2021 02:21

Make APIs which do not generate events "partial" in Oculus Browser.

d5d846b

ddbeck requested changes Oct 26, 2021

View reviewed changes

Elchi3 mentioned this pull request Nov 3, 2021

Add XRPose.{angular,linear}Velocity #11813

Closed

Elchi3 mentioned this pull request Feb 9, 2022

OWD Project Proposal: WebXR Browser Compatibility openwebdocs/project#35

Closed

queengooborg added the rebase needed 🚧 label Feb 19, 2022

queengooborg mentioned this pull request Apr 20, 2022

Add Oculus (Quest) Browser to BCD #15923

Merged

queengooborg added the semver-minor-bump A change that adds a new, non-potentially-breaking feature for consumers label Apr 22, 2022

dominiccooney closed this Apr 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Oculus Browser to browsers, and compatibility data for api/A* #12642

Add Oculus Browser to browsers, and compatibility data for api/A* #12642

dominiccooney commented Sep 29, 2021

lukewarlow Sep 29, 2021

dominiccooney Sep 30, 2021

lukewarlow Sep 29, 2021

dominiccooney Sep 30, 2021

lukewarlow Sep 29, 2021

dominiccooney Sep 30, 2021

dominiccooney commented Sep 30, 2021

dominiccooney commented Sep 30, 2021 •

edited

Loading

lukewarlow Sep 30, 2021 •

edited

Loading

lukewarlow Sep 30, 2021

ddbeck Oct 26, 2021

queengooborg commented Sep 30, 2021

dominiccooney commented Oct 3, 2021

queengooborg commented Oct 4, 2021

dominiccooney commented Oct 6, 2021

queengooborg commented Oct 6, 2021

dominiccooney commented Oct 12, 2021

ddbeck left a comment

ddbeck Oct 26, 2021

ddbeck Oct 26, 2021

ddbeck Oct 26, 2021

ddbeck Oct 26, 2021

ddbeck Oct 26, 2021

ddbeck Oct 26, 2021

Elchi3 commented Nov 15, 2021

queengooborg commented Apr 20, 2022

dominiccooney commented Apr 23, 2022

Add Oculus Browser to browsers, and compatibility data for api/A* #12642

Add Oculus Browser to browsers, and compatibility data for api/A* #12642

Conversation

dominiccooney commented Sep 29, 2021

Summary

Test results and supporting details

Related issues

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominiccooney commented Sep 30, 2021

dominiccooney commented Sep 30, 2021 • edited Loading

lukewarlow Sep 30, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

queengooborg commented Sep 30, 2021

dominiccooney commented Oct 3, 2021

queengooborg commented Oct 4, 2021

dominiccooney commented Oct 6, 2021

queengooborg commented Oct 6, 2021

dominiccooney commented Oct 12, 2021

ddbeck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Elchi3 commented Nov 15, 2021

queengooborg commented Apr 20, 2022

dominiccooney commented Apr 23, 2022

dominiccooney commented Sep 30, 2021 •

edited

Loading

lukewarlow Sep 30, 2021 •

edited

Loading