Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing features for DOMRect API #11679

Merged
merged 6 commits into from
Aug 10, 2021
Merged

Add missing features for DOMRect API #11679

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
19fd185
Add missing features for DOMRect API
queengooborg Jul 22, 2021
487d560
Remove 404 URLs
queengooborg Jul 22, 2021
75d0ece
Fix spec URLs from code review
queengooborg Jul 23, 2021
aa51d7b
Update version numbers
queengooborg Jul 23, 2021
287fd4d
Apply suggestions from code review
queengooborg Aug 3, 2021
911b933
Apply suggestions from code review
foolip Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
198 changes: 198 additions & 0 deletions api/DOMRect.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,106 @@
}
}
},
"height": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/height",
queengooborg marked this conversation as resolved.
Show resolved Hide resolved
"spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-height",
queengooborg marked this conversation as resolved.
Show resolved Hide resolved
"support": {
"chrome": {
"version_added": "61"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version_added": "61"
"version_added": "2"

For the properties that were on ClientRect, I think we should mark support as going back that far. That's what we do with other prefixed and alt.name. entries.

},
"chrome_android": {
"version_added": "61"
},
"edge": {
"version_added": "79"
},
"firefox": {
"version_added": "27"
},
"firefox_android": {
"version_added": "27"
},
"ie": {
"version_added": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version_added": false,
"version_added": "4",

And no note needed. These were copied from DOMRectReadOnly.json but I think we should remove everything about ClientRect from there, including the notes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've sent #11694 for that.

"notes": "Implemented on the proprietary <code><a href='https://msdn.microsoft.com/en-us/library/hh826029(VS.85).aspx'>ClientRect</a></code> interface."
},
"opera": {
"version_added": "48"
},
"opera_android": {
"version_added": "45"
},
"safari": {
"version_added": "10.1"
},
"safari_ios": {
"version_added": "10.3"
},
"samsunginternet_android": {
"version_added": "8.0"
queengooborg marked this conversation as resolved.
Show resolved Hide resolved
},
"webview_android": {
"version_added": "61"
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"width": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/width",
"spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-width",
queengooborg marked this conversation as resolved.
Show resolved Hide resolved
"support": {
"chrome": {
"version_added": "61"
},
"chrome_android": {
"version_added": "61"
},
"edge": {
"version_added": "79"
},
"firefox": {
"version_added": "27"
},
"firefox_android": {
"version_added": "27"
},
"ie": {
"version_added": false,
"notes": "Implemented on the proprietary <code><a href='https://msdn.microsoft.com/en-us/library/hh826029(VS.85).aspx'>ClientRect</a></code> interface."
},
"opera": {
"version_added": "48"
},
"opera_android": {
"version_added": "45"
},
"safari": {
"version_added": "10.1"
},
"safari_ios": {
"version_added": "10.3"
},
"samsunginternet_android": {
"version_added": "8.0"
queengooborg marked this conversation as resolved.
Show resolved Hide resolved
},
"webview_android": {
"version_added": "61"
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"worker_support": {
"__compat": {
"description": "Available in workers",
Expand Down Expand Up @@ -272,6 +372,104 @@
"deprecated": false
}
}
},
"x": {
foolip marked this conversation as resolved.
Show resolved Hide resolved
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/x",
"spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-x",
queengooborg marked this conversation as resolved.
Show resolved Hide resolved
"support": {
"chrome": {
"version_added": "61"
},
"chrome_android": {
"version_added": "61"
},
"edge": {
"version_added": "79"
},
"firefox": {
"version_added": "31"
},
"firefox_android": {
"version_added": "31"
},
"ie": {
"version_added": false
},
"opera": {
"version_added": "48"
},
"opera_android": {
"version_added": "45"
},
"safari": {
"version_added": "10.1"
},
"safari_ios": {
"version_added": "10.3"
},
"samsunginternet_android": {
"version_added": "8.0"
},
"webview_android": {
"version_added": "61"
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"y": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/DOMRectReadOnly/y",
"spec_url": "https://drafts.fxtf.org/geometry/#dom-domrectreadonly-y",
queengooborg marked this conversation as resolved.
Show resolved Hide resolved
"support": {
"chrome": {
"version_added": "61"
},
"chrome_android": {
"version_added": "61"
},
"edge": {
"version_added": "79"
},
"firefox": {
"version_added": "31"
},
"firefox_android": {
"version_added": "31"
},
"ie": {
"version_added": false
},
"opera": {
"version_added": "48"
},
"opera_android": {
"version_added": "45"
},
"safari": {
"version_added": "10.1"
},
"safari_ios": {
"version_added": "10.3"
},
"samsunginternet_android": {
"version_added": "8.0"
},
"webview_android": {
"version_added": "61"
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
}
}
}
Expand Down