Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ClientRect alternative name and notes from DOMRectReadOnly #11694

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Jul 23, 2021

This is already represented on DOMRect for all browsers.

This is already represented on DOMRect for all browsers.
@foolip foolip requested a review from queengooborg July 23, 2021 13:11
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 23, 2021
@queengooborg queengooborg merged commit c799146 into main Jul 23, 2021
@queengooborg queengooborg deleted the DOMRectReadOnly-no-ClientRect branch July 23, 2021 16:27
foolip added a commit to foolip/browser-compat-data that referenced this pull request Aug 10, 2021
Since the properties top, right, bottom and left are on DOMRectReadOnly,
it's necessary to treat ClientRect as an alias of both DOMRect and
DOMRectReadOnly. See discussion starting here:
mdn#11679 (comment)

This reverts mdn#11694 but
goes much further in representing the ClientRect support than before.
@foolip
Copy link
Contributor Author

foolip commented Aug 10, 2021

I've sent #11960 which effectively reverts this.

ddbeck pushed a commit that referenced this pull request Aug 18, 2021
Since the properties top, right, bottom and left are on DOMRectReadOnly,
it's necessary to treat ClientRect as an alias of both DOMRect and
DOMRectReadOnly. See discussion starting here:
#11679 (comment)

This reverts #11694 but
goes much further in representing the ClientRect support than before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants