Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgtool: fix "align" script error #1878

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

butok
Copy link
Contributor

@butok butok commented Dec 19, 2023

Fix "align" possible script error, caused by #1833

Fix "align" possible script error, caused by mcu-tools#1833.
Set default value for the align parameter.

Signed-off-by: Andrej Butok <[email protected]>
Copy link
Member

@d3zd3z d3zd3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so sure about 1 being the default, but it is fine to give this a default.

The other option would be to make this actually option, not just a default, and require it to be specified in configurations that is needed.

@d3zd3z d3zd3z merged commit 06bc548 into mcu-tools:main Feb 7, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants