Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgtool: make "align" command line parameter optional #1833

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

butok
Copy link
Contributor

@butok butok commented Oct 5, 2023

"Align" parameter should be optional:

  • it has a default value.
  • it is not used for non-swap update modes.

Align parameter should be optional:
- it has a default value.
- it is not used for non-swap update modes.

Signed-off-by: Andrej Butok <[email protected]>
@d3zd3z d3zd3z merged commit 25b7c7a into mcu-tools:main Nov 1, 2023
55 checks passed
@mingulov
Copy link
Contributor

Sorry could someone clarify how it was intended to work / where it works?

For me without 'align' option I receive an exception on 'align=int(align)':
TypeError: int() argument must be a string, a bytes-like object or a real number, not 'NoneType'

@butok
Copy link
Contributor Author

butok commented Dec 18, 2023

Sorry could someone clarify how it was intended to work / where it works?

For me without 'align' option I receive an exception on 'align=int(align)': TypeError: int() argument must be a string, a bytes-like object or a real number, not 'NoneType'

Interesting, why we are using align=int(align).
All other integer parameters do not have such approach ( slot_size=slot_size, max_sectors=max_sectors, max_align=max_align etc.).
Guess, we should delete int(). May we?

butok added a commit to butok/mcuboot that referenced this pull request Dec 19, 2023
Fix "align" possible script error, caused by mcu-tools#1833

Signed-off-by: Andrej Butok <[email protected]>
butok added a commit to butok/mcuboot that referenced this pull request Jan 16, 2024
Fix "align" possible script error, caused by mcu-tools#1833.
Set default value for the align parameter.

Signed-off-by: Andrej Butok <[email protected]>
d3zd3z pushed a commit that referenced this pull request Feb 7, 2024
Fix "align" possible script error, caused by #1833.
Set default value for the align parameter.

Signed-off-by: Andrej Butok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants