-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ws 243 export favourites as openlp service #244
Merged
sskjames
merged 30 commits into
master
from
feature/WS-243-export-favourites-as-openlp-service
Apr 15, 2021
Merged
Feature/ws 243 export favourites as openlp service #244
sskjames
merged 30 commits into
master
from
feature/WS-243-export-favourites-as-openlp-service
Apr 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… header json. Elements not fully supported yet: footer, audit, data, xml_version
…ta elements in service item.
…ultiple authors.
…iceitem:header:data correctly when there are multiple authors - Added support to build the serviceitem:header:audit element correctly when there are multiple authors
…e (right now only the json). - The JSON shall be encoded in us-ascii. - Added support to encode the "titles" in json xml_version as ascii string.
- the <lines> element in xml_version - the "title" and "raw_slide" json elements.
…ped in the xml_version. - Ensured that the character "\" is not escaped in the final json string.
… OpenLP formats it.
…voritesTableViewController.
sundarsabapathi
approved these changes
Apr 15, 2021
sibiarunachalam
approved these changes
Apr 15, 2021
SonarQube Quality Gate |
VigneshPalanisamy
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.