Ability to export Favourite song list as OpenLP service #243

sskjames · 2021-03-18T03:42:23Z

… header json. Elements not fully supported yet: footer, audit, data, xml_version

…ta elements in service item.

…ultiple authors.

…iceitem:header:data correctly when there are multiple authors - Added support to build the serviceitem:header:audit element correctly when there are multiple authors

… of song.

… song.

…ines.

sskjames · 2021-03-30T00:59:39Z

service-file-created-by-app.osj.txt

As of now, this is the JSON created by the app.
I zipped this file with the extension oszl and tried to open it from OpenLP but got the following error:

Traceback (most recent call last):
  File "openlp/core/ui/servicemanager.py", line 440, in on_load_service_clicked
  File "openlp/core/ui/servicemanager.py", line 755, in load_file
  File "json/__init__.py", line 265, in load
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/encodings/ascii.py", line 26, in decode
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe0 in position 801: ordinal not in range(128)

UPDATE:
This error was because by default, SwiftyJSON prints a pretty JSON. When switched to a compact output, I didn't see this error.

sskjames · 2021-03-30T01:13:44Z

Interestingly, I got the same error when I extracted a oszl file created by OpenLP and re-zipped again with the extension oszl and tried to open it in OpenLP.

UPDATE:
This error was because I formatted the JSON to make it readable.

sskjames · 2021-03-30T05:33:06Z

Now getting this error:

Traceback (most recent call last):
  File "openlp/core/common/openlpmixin.py", line 58, in wrapped
  File "openlp/core/common/openlpmixin.py", line 54, in wrapped
  File "openlp/core/ui/servicemanager.py", line 440, in on_load_service_clicked
  File "openlp/core/common/openlpmixin.py", line 58, in wrapped
  File "openlp/core/common/openlpmixin.py", line 54, in wrapped
  File "openlp/core/ui/servicemanager.py", line 766, in load_file
  File "openlp/core/common/openlpmixin.py", line 58, in wrapped
  File "openlp/core/common/openlpmixin.py", line 54, in wrapped
  File "openlp/core/ui/servicemanager.py", line 825, in process_service_items
  File "openlp/plugins/songs/lib/mediaitem.py", line 555, in service_load
  File "openlp/plugins/songs/lib/openlyricsxml.py", line 371, in xml_to_song
  File "src/lxml/lxml.objectify.pyx", line 1801, in lxml.objectify.fromstring (src/lxml/lxml.objectify.c:25171)
  File "src/lxml/lxml.etree.pyx", line 3213, in lxml.etree.fromstring (src/lxml/lxml.etree.c:77697)
  File "src/lxml/parser.pxi", line 1819, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:116494)
  File "src/lxml/parser.pxi", line 1700, in lxml.etree._parseDoc (src/lxml/lxml.etree.c:115040)
  File "src/lxml/parser.pxi", line 1040, in lxml.etree._BaseParser._parseUnicodeDoc (src/lxml/lxml.etree.c:109165)
  File "src/lxml/parser.pxi", line 573, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:103404)
  File "src/lxml/parser.pxi", line 683, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:105058)
  File "src/lxml/parser.pxi", line 613, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:103967)
  File "<string>", line None
lxml.etree.XMLSyntaxError: Start tag expected, '<' not found, line 1, column 1

sskjames · 2021-03-31T01:44:21Z

Facing the encoding issue again.

Traceback (most recent call last):
  File "openlp/core/ui/servicemanager.py", line 440, in on_load_service_clicked
  File "openlp/core/ui/servicemanager.py", line 755, in load_file
  File "json/__init__.py", line 265, in load
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/encodings/ascii.py", line 26, in decode
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe0 in position 1994: ordinal not in range(128)

The osj file which I created had the encoding utf-8

sskjames · 2021-04-01T01:24:15Z

Observed the the service file json created by OpenLP 2.4.6 has the encoding "us-ascii" even when Tamil language songs are included.

service-with-tamil-song.osj.txt

sskjames · 2021-04-01T01:27:53Z

Does OpenLP 2.4.6 support service data files with utf-8 encoding?
We have a few options:

Use "us-ascii" encoding and encode the data in ascii.
Check whether the latest version of OpenLP (2.9.x but is not public yet) supports "utf-8" encoding.

sskjames · 2021-04-01T02:18:13Z

Raised this concern as a question in the OpenLP forum

sskjames · 2021-04-05T01:21:06Z

Installing OpenLP 2.9.2 aka 3.0 Beta 1 to check whether the service files can be opened in it.

sskjames · 2021-04-05T01:38:34Z

Tried to open the service file (created by the app) in OpenLP 2.9.2 and didn't get the encoding error. However, the xml error was still thrown.
Created a service with a Tamil song in OpenLP 2.9.2 and found the encoding to be us-ascii.
Looks like OpenLP expects the service_data json file with the encoding us-ascii.

sskjames · 2021-04-16T01:36:42Z

Observed some problems in the build uploaded to TestFlight.

melissadarsh · 2021-04-16T06:50:25Z

Performed the steps below during testing:

Added 6 songs into favourites
Tapped on the share option and shared as OpenLP Service.
Shared the file through email.
Downloaded the file and opened it in the OpenLP Service desktop app.
Observed: Favourite songs appear on the service manager and songs were successfully presented.
Repeated the above steps with another favourite list.
Same is observed.

Tested on iOS14.4.

Note: The sharing option should include sharing through airdrop & sharing to the iOS OpenLP app

…ong after retrieving it from the db.

…es-as-openlp-service #243 Ensured that the i18nTitle and mediaUrl are set properly for a song

sskjames · 2021-04-16T10:09:49Z

As part of the refactoring, I introduced another bug which causes only the i18nTitle to be displayed for the songs irrespective of the language they selected. Need to fix this.

sskjames · 2021-04-19T00:58:39Z

As part of the refactoring, I introduced another bug which causes only the i18nTitle to be displayed for the songs irrespective of the language they selected. Need to fix this.

Performed the steps below during testing:

1. Added 6 songs into favourites

2. Tapped on the share option and shared as OpenLP Service.

3. Shared the file through email.

4. Downloaded the file and opened it in the OpenLP Service desktop app.

5. Observed: Favourite songs appear on the service manager and songs were successfully presented.

6. Repeated the above steps with another favourite list.

7. Same is observed.

Tested on iOS14.4.

Note: The sharing option should include sharing through airdrop & sharing to the iOS OpenLP app

Thanks @melissadarsh for the testing and feedback. Can we address sharing through airdrop in a separate issue? And I think, the iOS OpenLP app is just a remote to the desktop app.

sskjames · 2021-04-19T02:54:59Z

OpenLP couldn't open the service file created by the app if the favourites has a song without a verse order.
To be specific, in the JSON data, the [serviceitem][data] is not constructed properly if the song does not have a verse order.

… is Tamil.

…t defined while sharing as OpenLP service

… of a song

pixel2user · 2021-04-27T14:42:00Z

I exported an oszl file (favorite_renamed_extension.oszl.zip, renamed for upload) via the iOS app (installed via TestFlight today) and opened that file in OpenLP 2.4.6 (Windows). I got the following error message, but was able to see the lyrics of both songs afterwards.

Traceback (most recent call last):
File "openlp\core\ui\servicemanager.py", line 440, in on_load_service_clicked
File "openlp\core\ui\servicemanager.py", line 766, in load_file
File "openlp\core\ui\servicemanager.py", line 828, in process_service_items
File "openlp\core\ui\servicemanager.py", line 1408, in add_service_item
File "openlp\core\lib\serviceitem.py", line 259, in render
KeyError: 'raw_slide'

sskjames · 2021-04-29T06:10:51Z

I exported an oszl file (favorite_renamed_extension.oszl.zip, renamed for upload) via the iOS app (installed via TestFlight today) and opened that file in OpenLP 2.4.6 (Windows). I got the following error message, but was able to see the lyrics of both songs afterwards.

Traceback (most recent call last):
File "openlp\core\ui\servicemanager.py", line 440, in on_load_service_clicked
File "openlp\core\ui\servicemanager.py", line 766, in load_file
File "openlp\core\ui\servicemanager.py", line 828, in process_service_items
File "openlp\core\ui\servicemanager.py", line 1408, in add_service_item
File "openlp\core\lib\serviceitem.py", line 259, in render
KeyError: 'raw_slide'

Hi @GermanGospel, thank you very much for taking time to test this out and report it to us.
I'll look into it.

sskjames · 2021-04-30T09:51:09Z

Hi @GermanGospel, I exported the same songs which you did (Amazing Grace, God of Grace and God of Glory) and I could open it without any issues in OpenLP 2.4.6 (Mac OS 10.15). I'll test this out in Windows as well.

Which build did you use from TestFlight? Is it 3.1.0 (17)?

sskjames · 2021-04-30T10:04:25Z

Hit the problem with OpenLP 2.4.6 (Windows).

sskjames · 2021-05-16T05:49:12Z

I tested this again in Windows and Mac with many different songs but I couldn't recreate the problem.

sskjames self-assigned this Mar 18, 2021

sskjames added this to the 3.0.0 milestone Mar 18, 2021

sskjames added the feature label Mar 18, 2021

sskjames added a commit that referenced this issue Mar 19, 2021

#243 Added support to build the general service info json.

03579bf

sskjames added a commit that referenced this issue Mar 19, 2021

#243 Renamed the json file and moved it to a folder.

022e948

sskjames added a commit that referenced this issue Mar 19, 2021

#243 Added support to construct most of the items in the service item…

ada60fd

… header json. Elements not fully supported yet: footer, audit, data, xml_version

sskjames added a commit that referenced this issue Mar 19, 2021

#243 Added support to include a single author in footer, audit and da…

030eaa7

…ta elements in service item.

sskjames added a commit that referenced this issue Mar 19, 2021

#243 Updated the songs database to ensure that there are songs with m…

918a79d

…ultiple authors.

sskjames added a commit that referenced this issue Mar 22, 2021

#243 Added support to format the footer authors in the expected format

dfda48f

sskjames mentioned this issue Mar 24, 2021

Ability to export Favourite song list as OpenLP service mcruncher/worshipsongs-android#221

Open

sskjames added a commit that referenced this issue Mar 24, 2021

#243 Added support to build the properties element in the xml version…

7634ef0

… of song.

sskjames added a commit that referenced this issue Mar 24, 2021

#243 Added support to build lyrics element in the xml version of song

8e7da67

sskjames linked a pull request Mar 25, 2021 that will close this issue

Feature/ws 243 export favourites as openlp service #244

Merged

sskjames added a commit that referenced this issue Mar 25, 2021

#243 Minor refactoring

79f7cd7

sskjames added a commit that referenced this issue Mar 25, 2021

#243 Added support to construct the "data" element in service item.

e1f9342

sskjames added a commit that referenced this issue Mar 26, 2021

#243 Added support to include the "modifiedDate" in the xml vesion of…

755c007

… song.

sskjames added a commit that referenced this issue Mar 26, 2021

#243 Ensured that the xml version of the song is compact without newl…

81b343b

…ines.

sskjames added a commit that referenced this issue Mar 30, 2021

#243 Improved the acceptance test

a82d4a9

sskjames reopened this Apr 16, 2021

sskjames added a commit that referenced this issue Apr 16, 2021

#243 Ensured that the i18nTitle and mediaUrl are set properly for a s…

d82d6fe

…ong after retrieving it from the db.

sskjames linked a pull request Apr 16, 2021 that will close this issue

#243 Ensured that the i18nTitle and mediaUrl are set properly for a song #251

Merged

sskjames closed this as completed in #251 Apr 16, 2021

sskjames added a commit that referenced this issue Apr 16, 2021

Merge pull request #251 from mcruncher/feature/WS-243-export-favourit…

58bbf60

…es-as-openlp-service #243 Ensured that the i18nTitle and mediaUrl are set properly for a song

sskjames reopened this Apr 16, 2021

sskjames added a commit that referenced this issue Apr 19, 2021

#243 The title cell text shall display i18nTitle only if the language…

9e021c5

… is Tamil.

sskjames added a commit that referenced this issue Apr 19, 2021

#243 Verse order shall be interpreted from the song data if one is no…

c7355b2

…t defined while sharing as OpenLP service

sskjames linked a pull request Apr 19, 2021 that will close this issue

Feature/ws 243 export favourites as openlp service #253

Merged

sskjames added a commit that referenced this issue Apr 20, 2021

#243 Search by title/content now would also search by alternate title…

f8a6cdc

… of a song

sskjames closed this as completed Apr 21, 2021

sskjames added this to the 3.1.0 milestone Apr 23, 2021

sskjames reopened this Apr 29, 2021

sskjames closed this as completed May 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ability to export Favourite song list as OpenLP service #243

Ability to export Favourite song list as OpenLP service #243

sskjames commented Mar 18, 2021

sskjames commented Mar 30, 2021 •

edited

Loading

sskjames commented Mar 30, 2021 •

edited

Loading

sskjames commented Mar 30, 2021

sskjames commented Mar 31, 2021

sskjames commented Apr 1, 2021

sskjames commented Apr 1, 2021

sskjames commented Apr 1, 2021

sskjames commented Apr 5, 2021

sskjames commented Apr 5, 2021

sskjames commented Apr 16, 2021

melissadarsh commented Apr 16, 2021 •

edited

Loading

sskjames commented Apr 16, 2021

sskjames commented Apr 19, 2021

sskjames commented Apr 19, 2021

pixel2user commented Apr 27, 2021 •

edited

Loading

sskjames commented Apr 29, 2021

sskjames commented Apr 30, 2021

sskjames commented Apr 30, 2021

sskjames commented May 16, 2021

Ability to export Favourite song list as OpenLP service #243

Ability to export Favourite song list as OpenLP service #243

Comments

sskjames commented Mar 18, 2021

sskjames commented Mar 30, 2021 • edited Loading

sskjames commented Mar 30, 2021 • edited Loading

sskjames commented Mar 30, 2021

sskjames commented Mar 31, 2021

sskjames commented Apr 1, 2021

sskjames commented Apr 1, 2021

sskjames commented Apr 1, 2021

sskjames commented Apr 5, 2021

sskjames commented Apr 5, 2021

sskjames commented Apr 16, 2021

melissadarsh commented Apr 16, 2021 • edited Loading

sskjames commented Apr 16, 2021

sskjames commented Apr 19, 2021

sskjames commented Apr 19, 2021

pixel2user commented Apr 27, 2021 • edited Loading

sskjames commented Apr 29, 2021

sskjames commented Apr 30, 2021

sskjames commented Apr 30, 2021

sskjames commented May 16, 2021

sskjames commented Mar 30, 2021 •

edited

Loading

sskjames commented Mar 30, 2021 •

edited

Loading

melissadarsh commented Apr 16, 2021 •

edited

Loading

pixel2user commented Apr 27, 2021 •

edited

Loading