update from fork #32
Merged
update from fork #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Addressed
Note any issues addressed by this change with one
Fixes #statement per line.Proposed Changes
Describe your proposed changes. Focus on providing additional context that
may not be visible in the code itself. Why did you take the approach that you
did? What other approaches were considered? If this is a complex change,
provide some architectural context so reviewers understand how the pieces
fit together.
Testing
New code must include tests to validate behavior. If you could not adequately
automate some aspects of the testing, please describe why and what needs to
be done to validate functionality in the future.
Describe how you tested these changes. Consult the project developer readme
for guidance on what to test and how.