dynamic provider factory #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 23, 2019 23:09
added 2 commits
November 25, 2019 10:31
mcred
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This adds some baseline infrastructure to support multiple contexts properly in the CLI. This ditches the global provider and instead derives it within each command. There are three cases:
byRepository)byRepositoryName)default)In the future, we'll be able to distinguish repos by name (e.g. "kubernetes/foo"), looking at existing repositories, and having a config file with the default provider set.
There are a few commands that are a bit odd: install, uninstall and upgrade. Until we fully flesh out the context-specific commands, I've just left them as untouched as possible.
Testing
mvn installand e2e getting started tests.