Keep original type when using hasProperty if defined (MetaMask#94)

Keep original type when using hasProperty if defined
mcmire · Apr 11, 2023 · e5af1f4 · e5af1f4
1 parent 770e727
commit e5af1f4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/merged-packages/utils/src/misc.test-d.ts b/merged-packages/utils/src/misc.test-d.ts
@@ -89,6 +89,16 @@ class HasPropertyClassExample {
 const hasPropertyClassExample = new HasPropertyClassExample();
 hasProperty(hasPropertyClassExample, 'a');
 
+type HasPropertyTypeExample = {
+  a?: number;
+};
+
+// It keeps the original type when defined.
+const hasPropertyTypeExample: HasPropertyTypeExample = {};
+if (hasProperty(hasPropertyTypeExample, 'a')) {
+  expectType<number | undefined>(hasPropertyTypeExample.a);
+}
+
 //=============================================================================
 // RuntimeObject
 //=============================================================================

diff --git a/merged-packages/utils/src/misc.ts b/merged-packages/utils/src/misc.ts
@@ -93,8 +93,11 @@ export const hasProperty = <
 >(
   objectToCheck: ObjectToCheck,
   name: Property,
-): objectToCheck is ObjectToCheck & Record<Property, unknown> =>
-  Object.hasOwnProperty.call(objectToCheck, name);
+): objectToCheck is ObjectToCheck &
+  Record<
+    Property,
+    Property extends keyof ObjectToCheck ? ObjectToCheck[Property] : unknown
+  > => Object.hasOwnProperty.call(objectToCheck, name);
 
 export type PlainObject = Record<number | string | symbol, unknown>;