Bugfix: remove and ignore assets #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
Keep original type when using hasProperty if defined
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* add remove and ignore assets methods * tests
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* add remove and ignore assets methods * tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR maintain changes made in #86 adding specific methods to remove and ignore assets, and maintaining remove assets methods before that PR.
The motivation of this is to maintain independent methods in
AssetsController. This change produced that all removed assets would be immediately ignored without having an option to remove without ignore.