Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NanoDMX/StageProfi/Enttec fix #1446

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

brianwiddas
Copy link
Contributor

For any value over 127, the nanodmx code sends the update to the device repeatedly rather than just once, as happens for any value <= 127

This is caused by a signed/unsigned value comparison in nanodmx.cpp

Fixed and tested. Also fixed the same code in stageprofi.cpp and enttecdmxusbpro.cpp, but not tested.

Make the universeData == compareData test unsigned for both,
otherwise it will continuously resend any value above 127
Make universeData == compareData check unsigned, same as NanoDMX
@mcallegari
Copy link
Owner

Thanks for the patch, makes sense!
However, looking at the code, maybe the right way is to declare 'val' as char, since it comes and goes into QByteArrays.
What do you think?

As discussed in pull request mcallegari#1446, use char rather
than uchar, as that is the native type of a QByteArray
@coveralls
Copy link

Coverage Status

coverage: 28.054%. remained the same when pulling 023552a on brianwiddas:nanodmx-compare into 04956e8 on mcallegari:master.

@brianwiddas
Copy link
Contributor Author

Hi,

Yes, that makes sense. I looked over the code for all three and can't see any reason why it would be a problem.

Updated the code and tested nanodmx

@mcallegari mcallegari merged commit 1f37df3 into mcallegari:master Aug 7, 2023
5 checks passed
@mcallegari
Copy link
Owner

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants