Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NanoDMX/StageProfi/Enttec fix #1446

Merged
merged 3 commits into from
Aug 7, 2023
Merged

NanoDMX/StageProfi/Enttec fix #1446

merged 3 commits into from
Aug 7, 2023

Commits on Aug 5, 2023

  1. Fix compareData comparison for NanoDMX 

    Make the universeData == compareData test unsigned for both,
otherwise it will continuously resend any value above 127
    @brianwiddas
    brianwiddas committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    92cdab1 View commit details
    Browse the repository at this point in the history

  2. Fix compareData check for StageProfi/Enttec 

    Make universeData == compareData check unsigned, same as NanoDMX
    @brianwiddas
    brianwiddas committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    dc2b4f5 View commit details
    Browse the repository at this point in the history

  3. Replace uchar with char 

    As discussed in pull request mcallegari#1446, use char rather
than uchar, as that is the native type of a QByteArray
    @brianwiddas
    brianwiddas committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    023552a View commit details
    Browse the repository at this point in the history