Switch to new Software Quality metrics when decorating Pull Requests #995
+822
−1,135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sonarqube has deprecated the previous Bug, Vulnerability, and Code Smell rule types, instead replacing them with Software Quality attributes and a potential rating against multiple attributes for a single rule. As the rule types were only being used to report individual issues in the Gitlab and Azure decorators, and for creating the overall summary message to match what was previously shown on the Pull Request's overview within Sonarqube, the types have been removed from all decoration. Where summary messages are used in a decorator they now show equivalent information as is shown on the Pull Request overview page in Sonarqube - New issues, accepted issues, resolved issues, coverage, duplications, and security hotspot metrics, plus any failed quality gate conditions. Where the issue rating is reported in decoration, the highest rating across all the Software Qualities assigned to a rule is used in the new setup. The individual issues posted on Gitlab and Azure decorations have been simplified to only contain the message from the finding and the link to view the finding in Sonarqube, rather than including attributes about resolution time and issue type which are unlikely to have been useful to most users.