Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gitlab] Compact mode of file comments #139

Open
bmaehr opened this issue Mar 22, 2020 · 4 comments · May be fixed by #995
Open

[Gitlab] Compact mode of file comments #139

bmaehr opened this issue Mar 22, 2020 · 4 comments · May be fixed by #995
Labels
enhancement New feature or request

Comments

@bmaehr
Copy link

bmaehr commented Mar 22, 2020

Describe the Enhancement
Compact mode of file comments

Additional context
The file comments are much to bulky, so it should be possible to use a more compact form.

@bmaehr bmaehr added the bug Something isn't working label Mar 22, 2020
bmaehr added a commit to bmaehr/sonarqube-community-branch-plugin that referenced this issue Mar 22, 2020
Compact mode of file comments
@mc1arke mc1arke added enhancement New feature or request and removed bug Something isn't working labels Apr 27, 2020
@bmaehr
Copy link
Author

bmaehr commented Mar 8, 2021

I have reimplemented the change based on master if someone is interested ...

@phermsdorf
Copy link

Hi @bmaehr,

are this all changes required?

master...bmaehr:sonarqube-community-branch-plugin:patch-3

@mc1arke would you accept a pull request to incorporate this changes? (after the merge conflict is resolved)

Bye Peter

@bmaehr
Copy link
Author

bmaehr commented Jul 4, 2022

@phermsdorf "All changes required"? There are only 39 lines.

I submitted some patches a year ago including restructoring the the addiung/updating comments. Unfortunatlly they have never been accepted, so I stopped working on them. In the meantime a big refactoring has happend so applying them is not so easy. Perhaps I will do the rework at some time because I'm going to upgrade my Sonar but at the moment I don't have a timeframe and motivation for it.

@mc1arke
Copy link
Owner

mc1arke commented Nov 16, 2024

This should be resolved with the new comment structure in #995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants