#141 Implement updating comment instead of deleting and recreating #142
Conversation
Fixes mc1arke#85 (cherry picked from commit 9e9c59c)
There was a problem hiding this comment.
Thanks for your contribution. The intent of what your PR title says sounds like a great feature, but there seems to be additional changes in your PR that are doing unrelated things, including commits from other Pull Requests.
Please squash the commits you need to make this feature work, and drop any unrelated commits (submit them under a separate PR if you want those features!). Please also ensure your code is correctly indented to make it easier to read.
|
Yeah, there are things from the other pull request and a big refactoring. I will first make the other pull requests be accepted, then they are automatically eliminated here. |
| @@ -107,6 +119,27 @@ public BranchConfiguration load(Map<String, String> localSettings, ProjectBranch | |||
| return new DefaultBranchConfiguration(); | |||
| } | |||
|
|
|||
| private Map<String, String> autoConfigure(Map<String, String> localSettings) { | |||
There was a problem hiding this comment.
I'm really looking forward to seeing this in the next release!
| if (fileCommentEnabled) { | ||
| Map<String, String> headers = getHeaders(); | ||
| final String pullRequestId = analysis.getBranchName(); | ||
| final String mergeRequestDiscussionURL = getMergeRequestDiskussionsURL(pullRequestId); |
There was a problem hiding this comment.
This is the german spelling, it should use a c instead of a k. There are more variables and Methodnames with this typo.
|
@bmaehr good work! Looking forward to these features! |
|
@bmaehr are you still interested in progressing this feature? |
No description provided.