-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab PR decoration throws exception when no new_coverage condition is provided #85
Labels
bug
Something isn't working
Comments
tisoft
added a commit
to tisoft/sonarqube-community-branch-plugin
that referenced
this issue
Feb 12, 2020
mc1arke
pushed a commit
that referenced
this issue
Feb 17, 2020
Fixed in #87 |
bmaehr
pushed a commit
to bmaehr/sonarqube-community-branch-plugin
that referenced
this issue
Feb 22, 2020
Fixes mc1arke#85 (cherry picked from commit 9e9c59c)
Grintek
pushed a commit
to Grintek/sonarqube-community-branch-plugin
that referenced
this issue
Mar 13, 2020
…age Condition in analysis and replaced to "0" mc1arke#85
Merged
mc1arke
pushed a commit
that referenced
this issue
Apr 19, 2020
mc1arke
pushed a commit
that referenced
this issue
Apr 20, 2020
mc1arke
pushed a commit
that referenced
this issue
May 17, 2020
mc1arke
pushed a commit
that referenced
this issue
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When in Sonar conditions there is no new_coverage condition (and i doubt that this condition is necessary) the plugin throws Exception.
IllegalStateException("Could not find New Coverage Condition in analysis")
. I guess it's kinda related to #62 but the reason of the issue lies heresonarqube-community-branch-plugin/src/main/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/gitlab/GitlabServerPullRequestDecorator.java
Lines 153 to 155 in 1e28de6
The easiest solution would be
it's kinda duplicates the code from here
sonarqube-community-branch-plugin/src/main/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/AnalysisDetails.java
Lines 115 to 120 in 1e28de6
So may be we can put some duplicated lines into separate method from
AnalysisDetails.java
. I unfortunately have no idea how to implement fix nicelyExpected behavior
The plugin should not throw an exception. May be only log some info.
Screenshots
If applicable, add screenshots to help explain your problem.
Software Versions
The text was updated successfully, but these errors were encountered: