Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Reset ODS tables for new QLIK Snapshot #23

Merged
merged 1 commit into from
Sep 17, 2024
Merged

FEAT: Reset ODS tables for new QLIK Snapshot #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions src/cubic_loader/qlik/ods_qlik.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from cubic_loader.utils.aws import s3_object_exists
from cubic_loader.utils.aws import s3_split_object_path
from cubic_loader.utils.aws import s3_upload_file
from cubic_loader.utils.aws import s3_delete_object
from cubic_loader.utils.remote_locations import S3_ARCHIVE
from cubic_loader.utils.remote_locations import S3_ERROR
from cubic_loader.utils.remote_locations import QLIK
Expand Down Expand Up @@ -380,6 +381,19 @@ def rds_fact_table_load(self) -> None:

logger.log_complete()

def snapshot_reset(self) -> None:
"""
Reset database tables and status files for new snapshot

Those will lose all history from history table
"""

s3_delete_object(self.status_path)
self.etl_status = self.load_etl_status()

self.db.execute(drop_table(self.db_history_table))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell but are these within a db transaction. Also, do we need delete permissions for the database?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the self.db.execute call automatically creates it's own transaction, but each call is in its own transaction.

The application role should automatically have permission to drop these tables because the role also created them. That is generally standard in postgres.

self.db.execute(drop_table(self.db_fact_table))

def run_etl(self) -> None:
"""
Run table ETL Process
Expand All @@ -398,9 +412,15 @@ def run_etl(self) -> None:
last_cdc_ts=self.etl_status.last_cdc_ts,
)
try:
assert (
self.etl_status.current_snapshot_ts == self.last_s3_snapshot_dfm.ts
), f"Expected LOAD SNAPSHOT has changed from {self.etl_status.current_snapshot_ts} to {self.last_s3_snapshot_dfm.ts}"
if self.etl_status.current_snapshot_ts != self.last_s3_snapshot_dfm.ts:
new_snapshot_logger = ProcessLogger(
"ods_snapshot_change",
table=self.table,
old_shapshot=self.etl_status.current_snapshot_ts,
new_shapshot=self.last_s3_snapshot_dfm.ts,
)
self.snapshot_reset()
new_snapshot_logger.log_complete()

# create tables and history table partitions
# will be no-op if tables already exist
Expand Down
2 changes: 1 addition & 1 deletion src/cubic_loader/qlik/rds_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def drop_table(table_name: str) -> str:
"""
DROP table from RDS
"""
return f"DROP TABLE IF EXISTS {ODS_SCHEMA}.{table_name};"
return f"DROP TABLE IF EXISTS {ODS_SCHEMA}.{table_name} CASCADE;"


def add_columns_to_table(new_columns: List[DFMSchemaFields], fact_table: str) -> str:
Expand Down
Loading