FEAT: Reset ODS tables for new QLIK Snapshot #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grejdi-mbta
approved these changes
Sep 17, 2024
| s3_delete_object(self.status_path) | ||
| self.etl_status = self.load_etl_status() | ||
|
|
||
| self.db.execute(drop_table(self.db_history_table)) |
There was a problem hiding this comment.
I can't tell but are these within a db transaction. Also, do we need delete permissions for the database?
There was a problem hiding this comment.
the self.db.execute call automatically creates it's own transaction, but each call is in its own transaction.
The application role should automatically have permission to drop these tables because the role also created them. That is generally standard in postgres.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation of the ODS-QLIK RDS loader assumed that new snapshots would not be created. An assert check made sure that this condition stopped any loading operation if a new snapshot was detected.
This change loads new QLIK snapshots by totally wiping out the existing history and fact tables and loading the newest snapshot that is found.
With this implementation all transaction history will be lost any time cubic restarts the QLIK replication process.
This change requires that the application ECS be given DELETE permission for the application status files on S3.
Devops PR: https://github.com/mbta/devops/pull/2170