Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced method's name length #442

Merged
merged 1 commit into from
Dec 27, 2013
Merged

Reduced method's name length #442

merged 1 commit into from
Dec 27, 2013

Conversation

seuros
Copy link
Collaborator

@seuros seuros commented Dec 23, 2013

No description provided.

seuros referenced this pull request Dec 23, 2013
@bf4
Merge pull request #438 from bf4/fix_cached_tag_columns_check
5f87304 
[#432][#403][#433][#422] Fix checking for column cache until db connects
bf4
bf4 reviewed Dec 23, 2013
View reviewed changes
lib/acts_as_taggable_on/acts_as_taggable_on/cache.rb
@@ -43,7 +43,7 @@ def columns
end

module ClassMethods
def initialize_acts_as_taggable_on_cache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that method was never explicitly tested. (Its name is the the convention I was following in naming the methods I added)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there's any chance anyone might be calling that manually?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of a test (rspec, mini-test) maybe but unlikely. i don't think anyone will need to call it from within the controllers/helpers

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, based on working with you over these last few issues I would recommend you as additional maintainer of the project, if you're interested.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With great pleasure. Thank you

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @tilsammans @mbleigh @artemk I'm recommending @seuros as another co-maintainer. (And plz help with #441 if you can!)

bf4 added a commit that referenced this pull request Dec 27, 2013
@bf4
Merge pull request #442 from seuros/master
74d4254 
[MIsc] Reduced method's name length
@bf4 bf4 merged commit 74d4254 into mbleigh:master Dec 27, 2013
tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
@bf4
Merge pull request mbleigh#442 from seuros/master
60adcdd 
[MIsc] Reduced method's name length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seuros @bf4