Move cache table existence check in method #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to require a database connection during assets:precompile, which prevents deployment to Heroku
|
👍 to this issue |
|
+1 |
|
@tilsammans Should this still be aimed at 2-4 stable? |
|
If the branches haven't diverged, then sure. If it's too much trouble, I would just focus on master. I think at this point nobody is expecting 2-4-stability. |
|
@joelcogen would you mind re-submitting this PR against master, and perhaps outlining the difference in behavior between what is in master and in this PR. |
|
@bf4 I'll rebase onto master tonight and submit again |
|
Thanks, especially since #403 (comment) appears to have broken something else |
bf4
added a commit
to bf4/acts-as-taggable-on
that referenced
this pull request
Dec 19, 2013
… column cache until db connects Specifically see, mbleigh#432 (comment)
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
… column cache until db connects Specifically see, mbleigh#432 (comment)
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
[mbleigh#432][mbleigh#403][mbleigh#433][mbleigh#422] Fix checking for column cache until db connects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to require a database connection during assets:precompile, which prevents deployment to Heroku