Add github.token to actions/download-artifact #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of workflow_run.id in #67 wasn't enough. Tracing through the dorny/test-reporter code, I found that it was grabbing github.token as well. The actions/download-artifact README documentation now makes more sense: ```yaml # The GitHub token used to authenticate with the GitHub API. This is # required when downloading artifacts from a different repository or # from a different workflow run. # Optional. If unspecified, the action will download artifacts from # the current repo and the current workflow run. github-token: # The id of the workflow run where the desired download artifact was # uploaded from. If github-token is specified, this is the run that # artifacts will be downloaded from. # Optional. Default is ${{ github.run_id }} run-id: ``` Basically, I think both are needed here, based on what dorny/test-reporter appears to be doing.
mbland
added a commit
that referenced
this pull request
Dec 19, 2023
The overall "Publish Test Results" run for #68 failed, but _after_ that change caused the "Download test results" step to pass: - https://github.com/mbland/tomcat-servlet-testing-example/actions/runs/7268307692/job/19803882107 Tracing through the code, it seems that dorny/test-reporter does the following: - When `artifact:` is specified, it will check out the repo at github.event.workflow_run.head_commit.id. - When `artifact:` is _not_ specified, it assumes the repo is already present. This should, hopefully, provide the last missing piece for the test reporter to run successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of workflow_run.id in #67 wasn't enough. Tracing through the dorny/test-reporter code, I found that it was grabbing github.token as well. The actions/download-artifact README documentation now makes more sense:
Basically, I think both are needed here, based on what dorny/test-reporter appears to be doing.