Bump GitHub Actions: setup-java, upload-artifact #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: - actions/setup-java@v4 - actions/upload-artifact@v4
The previous commit bumped actions/upload-artifact in run-tests.yml to v4. The dorny/test-reporter@v1 action doesn't seem equipped to handle this upgrade, as the publish-test-results action on #66 failed. Using actions/download-artifact@v4 directly instead of relying on test-reporter seems like it should work.
|
GitHub Actions used the changes to run-tests.yml that included actions/upload-artifact@v4, but didn't use the changes to publish-test-results.yml that included actions/download-artifact@v4: Going to force merge and see what happens to the build on |
mbland
added a commit
that referenced
this pull request
Dec 19, 2023
The addition of actions/download-artifact@v4 to publish-test-results.yaml in #66 still failed: - https://github.com/mbland/tomcat-servlet-testing-example/actions/runs/7267779677/job/19802307107 What was interesting was the `run-id:` value from the "Download test results" step: Run actions/download-artifact@v4 with: name: test-results merge-multiple: false repository: mbland/tomcat-servlet-testing-example run-id: 7267779677 Downloading single artifact Error: Unable to download artifact(s): Artifact not found for name: test-results followed by this line from "Post test report": Action was triggered by workflow_run: using SHA and RUN_ID from triggering workflow So this change attempts to fix the breakage by adding `github.event.workflow_run.id` to the actions/download-artifact configuration.
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically: