Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stripJsonComments() trailing comma regexp #12

Merged
merged 1 commit into from
Dec 30, 2023

Replace stripJsonComments() trailing comma regexp

40fe838
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Replace stripJsonComments() trailing comma regexp #12

Replace stripJsonComments() trailing comma regexp
40fe838
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results succeeded Dec 30, 2023 in 0s

Test Results ✅

Tests passed successfully

✅ TESTS-TestSuites.xml

38 tests were completed in 1s with 38 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
test/analyzeArgv.test.js 9✅ 25ms
test/findFile.test.js 3✅ 7ms
test/getPath.test.js 3✅ 14ms
test/main.test.js 4✅ 694ms
test/runJsdoc.test.js 5✅ 464ms
test/stripJsonComments.test.js 14✅ 12ms

✅ test/analyzeArgv.test.js

✅ analyzeArgv > empty argv returns defaults
✅ analyzeArgv > destination not set if flag not followed by valid arg
✅ analyzeArgv > -d or --destination sets destination
✅ analyzeArgv > last -d wins
✅ analyzeArgv > -h, --help, -v, or --version sets willGenerate to false
✅ analyzeArgv > -c or --configure sets destination if opts defined
✅ analyzeArgv > last -c with opts defined wins
✅ analyzeArgv > -c with opts.destination undefined resets destination
✅ analyzeArgv > -d overrides -c

✅ test/findFile.test.js

✅ findFile > find file at root of tree
✅ findFile > find files using breadth-first search
✅ findFile > rejects when file not found

✅ test/getPath.test.js

✅ getPath > finds command on POSIX system
✅ getPath > finds command on Windows system
✅ getPath > rejects when command isn't found

✅ test/main.test.js

✅ jsdoc-cli-wrapper > success without index.html path
✅ jsdoc-cli-wrapper > error without index.html path
✅ jsdoc-cli-wrapper > success with index.html path
✅ jsdoc-cli-wrapper > emit internal error

✅ test/runJsdoc.test.js

✅ runJsdoc > emits error if jsdoc not found
✅ runJsdoc > returns success on -h, doesn't delete existing dir
✅ runJsdoc > deletes existing output and returns error
✅ runJsdoc > replaces existing output and returns success
✅ runJsdoc > deletes existing output and returns success

✅ test/stripJsonComments.test.js

✅ stripJsonComments > doesn't modify > the empty string
✅ stripJsonComments > doesn't modify > an object with plain strings and no comments
✅ stripJsonComments > doesn't modify > properly escaped strings
✅ stripJsonComments > doesn't modify > strings containing comment patterns
✅ stripJsonComments > doesn't modify > strings including trailing commas
✅ stripJsonComments > replaces > line comments, preserving existing whitespace
✅ stripJsonComments > replaces > block comments, preserving existing whitespace
✅ stripJsonComments > replaces > mixed comments and trailing commas before ] or }
✅ stripJsonComments > opens > a block comment if character after "*/" is '*'
✅ stripJsonComments > opens > a line comment if character after "*/" is '/'
✅ stripJsonComments > maintains correct syntax error position info when > * not preceded or followed by /
✅ stripJsonComments > maintains correct syntax error position info when > / not followed by /
✅ stripJsonComments > maintains correct syntax error position info when > multiple trailing commas are present
✅ stripJsonComments > maintains correct syntax error position info when > trailing commas don't follow an element or property