Replace stripJsonComments() trailing comma regexp #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized after merging #11 that the regular expression at the end of stripJsonComments() would affect quoted strings. The new "stripJsonComments > doesn't modify > strings including trailing commas" test case confirmed this. The new algorithm took a bit of trial and error, and the existing tests really helped distill it to its essence. Quite happy with how it turned out. Also reorganized the test cases with more `describe` blocks. Added the new "maintains correct syntax error position info when..." suite to confirm positional info in JSON.parse errors remains correct.
Pull Request Test Coverage Report for Build 7365167255
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized after merging #11 that the regular expression at the end of stripJsonComments() would affect quoted strings. The new "stripJsonComments > doesn't modify > strings including trailing commas" test case confirmed this.
The new algorithm took a bit of trial and error, and the existing tests really helped distill it to its essence. Quite happy with how it turned out.
Also reorganized the test cases with more
describeblocks. Added the new "maintains correct syntax error position info when..." suite to confirm positional info in JSON.parse errors remains correct.