Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up i18n translations #676

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Clean up i18n translations #676

merged 2 commits into from
Apr 25, 2024

Conversation

zachgoll
Copy link
Collaborator

My original reason for opening this was to fix the following error when running i18n-tasks add-missing:

(base) maybe $ i18n-tasks add-missing
/Users/zachgoll/.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/i18n-1.14.4/lib/i18n/backend/base.rb:65:in `translate': reserved key :default used in "Value. Interpolates: %{value}, %{human_key}, %{key}, %{default}, %{value_or_human_key}, %{value_or_default_or_human_key}" (I18n::ReservedInterpolationKey)

          raise ReservedInterpolationKey.new($1.to_sym, entry)

It looks like this is an upstream issue as pointed out here.

Given it's not critical to the project, I decided against any temporary workarounds. Instead, we'll just manually fill in translations until the upstream fix is implemented.

@zachgoll zachgoll merged commit da5021b into main Apr 25, 2024
4 checks passed
@zachgoll zachgoll deleted the fix-i18n-tasks branch April 25, 2024 18:41
@zachgoll zachgoll mentioned this pull request Apr 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant