Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up I18n translation paths #635

Closed
3 tasks
zachgoll opened this issue Apr 16, 2024 · 1 comment
Closed
3 tasks

Clean up I18n translation paths #635

zachgoll opened this issue Apr 16, 2024 · 1 comment

Comments

@zachgoll
Copy link
Collaborator

While we're currently only using en locale for translations, the directory structure and yaml key paths need to be cleaned up.

For example (one of many examples that can be cleaned up):

custom_turbo_confirm:
account_destroy:
accept: Delete "%{name}"
body_html: "<p>By deleting this account, you will erase its value history, affecting
various aspects of your overall account. This action will have a direct impact
on your net worth calculations and the account graphs.</p><br /> <p>After
deletion, there is no way you'll be able to restore the account information
because you'll need to add it as a new account.</p>"
title: Delete account?
default:
accept: Confirm
body_html: "<p>You will not be able to undo this decision</p>"
title: Are you sure?
history:
accept: Delete entry
body_html: "<p>Deleting this entry will remove it from the account’s history
which will impact different parts of your account. This includes the net worth
and account graphs.</p></br><p>The only way you’ll be able to add this entry
back is by re-entering it manually via a new entry</p>"
title: Delete Entry?

In this example, the path of the keys should map to the directory structure so we can benefit from lazy lookups in controllers and views.

Tasks

  • Make sure translations follow the directory structure of the project
  • Make sure i18n-tasks can run all commands (currently it is broken for i18n-tasks add-missing
  • ??? (there may be additional cleanup needed)
@zachgoll
Copy link
Collaborator Author

Closed by #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant