Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing arginfo #75

Merged
merged 1 commit into from
Nov 7, 2018
Merged

add missing arginfo #75

merged 1 commit into from
Nov 7, 2018

Conversation

remicollet
Copy link
Contributor

@remicollet remicollet commented Nov 7, 2018

Without this PR, reflection is missing important information

$ php  --re maxminddb
Extension [ <persistent> extension #113 maxminddb version 1.3.0 ] {

  - Classes [1] {
    Class [ <internal:maxminddb> class MaxMind\Db\Reader ] {

      - Constants [0] {
      }

      - Static properties [0] {
      }

      - Static methods [0] {
      }

      - Properties [0] {
      }

      - Methods [4] {
        Method [ <internal:maxminddb, ctor> public method __construct ] {
        }

        Method [ <internal:maxminddb> public method close ] {
        }

        Method [ <internal:maxminddb> public method get ] {
        }

        Method [ <internal:maxminddb> public method metadata ] {
        }
      }
    }
  }
}

With this PR

$ php -n -d extension=modules/maxminddb.so --re maxminddb
Extension [ <persistent> extension #15 maxminddb version 1.3.0 ] {

  - Classes [1] {
    Class [ <internal:maxminddb> class MaxMind\Db\Reader ] {

      - Constants [0] {
      }

      - Static properties [0] {
      }

      - Static methods [0] {
      }

      - Properties [0] {
      }

      - Methods [4] {
        Method [ <internal:maxminddb, ctor> public method __construct ] {

          - Parameters [1] {
            Parameter #0 [ <required> $db_file ]
          }
        }

        Method [ <internal:maxminddb> public method close ] {

          - Parameters [0] {
          }
        }

        Method [ <internal:maxminddb> public method get ] {

          - Parameters [1] {
            Parameter #0 [ <required> $ip_address ]
          }
        }

        Method [ <internal:maxminddb> public method metadata ] {

          - Parameters [0] {
          }
        }
      }
    }
  }
}

@oschwald
Copy link
Member

oschwald commented Nov 7, 2018

Nice! Thanks!

@oschwald oschwald merged commit 186d2a7 into maxmind:master Nov 7, 2018
oschwald added a commit that referenced this pull request Nov 8, 2018
oschwald added a commit that referenced this pull request Nov 9, 2018
PatrickCronin added a commit that referenced this pull request Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants