retrieve build options from pkg-config #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this PR, minimal library version is set to 0, can be raised later according to needs. I run test with 1.1.1 (RHEL-6) and 1.2.0 (RHEL-7), both are ok. |
oschwald
reviewed
Nov 7, 2018
ext/config.m4
Outdated
| AC_MSG_CHECKING(for libmaxminddb) | ||
| if test -x "$PKG_CONFIG" && $PKG_CONFIG --exists libmaxminddb; then | ||
| dnl retrieve build options from pkg-config | ||
| if $PKG_CONFIG libzip --atleast-version 0; then |
There was a problem hiding this comment.
Did you mean libmaxminddb here? I think we could probably require at least 1.0.0.
There was a problem hiding this comment.
indeed (so you know where I copy/past the code from ;)
Fixed
oschwald
added a commit
that referenced
this pull request
Nov 8, 2018
oschwald
added a commit
that referenced
this pull request
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects library during configure to fail early and avoid build error
I kept the old way (default path) as fallback, but raise a warning.