Upgrade SDK, Firebase, null_safety #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awhitford
reviewed
Mar 7, 2021
lib/src/firebase_image.dart
Outdated
| FirebaseImage( | ||
| String location, { | ||
| this.shouldCache = true, | ||
| this.scale = 1.0, | ||
| this.maxSizeBytes = 2500 * 1000, // 2.5MB | ||
| this.cacheRefreshStrategy = CacheRefreshStrategy.BY_METADATA_DATE, | ||
| this.firebaseApp, | ||
| required this.firebaseApp, |
There was a problem hiding this comment.
This breaking change should be documented in the change log and/or readme.
There was a problem hiding this comment.
Is this breaking change necessary?
There was a problem hiding this comment.
Agreed. firebaseApp is no longer required.
|
The top-level |
|
Actually, I think PR #30 is slightly better because it leverages the |
torstenek
force-pushed
the
null_safety
branch
3 times, most recently
from
680fab2 to
0c6b87d
Compare
Upgraded dependencies to SDK >=2.12.0 and Firebase_core ^1.0.0 along with required transitive dependencies. Works with SDK 2.13.0-77.0.dev
|
Using the late keyword is better. Changed it. Sorry for not spotting this in an earlier PR. |
|
Just merged PR #30. Thanks for your help though! |
|
NP 👍
…On Tue, 9 Mar 2021 at 15:43, Matt Reid ***@***.***> wrote:
Just merged PR #30 <#30>.
Thanks for your help though!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABKUWOTMXGGAJFFVCLMAVTTCYXZNANCNFSM4YX2KAVQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded dependencies to SDK >=2.12.0 and Firebase_core ^1.0.0 along with required transitive dependencies. Works with SDK 2.13.0-77.0.dev