Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to firebase_storage 8.0.0 and null safety #30

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

thearaks
Copy link
Contributor

@thearaks thearaks commented Mar 5, 2021

This PR should add Flutter 2.0 and Dart 2.12 compatibility.
Please review & test before merging!

@ycv005
Copy link

ycv005 commented Mar 6, 2021

@mattreid1 have a look at this pr.

@awhitford
Copy link
Contributor

The top-level pubspec.lock file should be removed (and added to .gitignore). It should not be committed for a library, only for an app.

See https://github.com/toptal/gitignore/blob/2d8160c7f607e142929d2ba213620a638e50603f/templates/Flutter.gitignore#L16

I like this PR over #32 because the late keyword is used to avoid a lot of ! operations.

@mattreid1
Copy link
Owner

I really like this one! I'm going to do some testing. Expect merge sometime tomorrow.

(I'm also working on CI/CD integration to make updating on pub.dev a bit easier.)

@mattreid1 mattreid1 merged commit fd49509 into mattreid1:master Mar 9, 2021
@thearaks thearaks deleted the feature/firebase_storage_8 branch October 13, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants