[MM-231] Sync the plugin with starter template #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#192) * Revert "Update main.go (#154)" This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475. * Revert "[MM-33506] Use embed package to include plugin manifest (#145)" This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f. * Revert "Don't generate manifest.ts (#127)" This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e. * install-go-tools target, adopt gotestsum * bring back make apply + automatic versioning * Update build/manifest/main.go Co-authored-by: Michael Kochell <[email protected]> * suppress git describe error when no tags match * make version/release notes opt-in * fix whitespace in Makefile * document version management options --------- Co-authored-by: Michael Kochell <[email protected]>
Co-authored-by: Jesse Hallam <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
=======================================
Coverage 23.71% 23.71%
=======================================
Files 62 62
Lines 3087 3087
=======================================
Hits 732 732
Misses 2274 2274
Partials 81 81 ☔ View full report in Codecov by Sentry. |
mickmister
approved these changes
Mar 14, 2024
|
@ayusht2810 Can you please resolve the conflicts here? Thank you |
mickmister
approved these changes
Mar 27, 2024
|
@raghavaggarwal2308 Can you please take a look at this PR? |
|
Not sure if the lint one is running correctly though. Looks like it just downloads the dependencies |
raghavaggarwal2308
approved these changes
Mar 29, 2024
|
@mickmister Should we move the PR to QA review? |
mickmister
added
3: QA Review
mickmister
reviewed
Apr 23, 2024
mickmister
approved these changes
May 24, 2024
AayushChaudhary0001
approved these changes
Jun 27, 2024
…lendar into MM-231
mickmister
added
4: Reviews Complete
mickmister
approved these changes
Jul 2, 2024
wiggin77
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Synced the plugin to include the below PRs:
Ticket Link