Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the 0 with 12 to indicate noon and midnight #127

Closed
DHaussermann opened this issue May 12, 2020 · 1 comment · Fixed by #139
Closed

Replace the 0 with 12 to indicate noon and midnight #127

DHaussermann opened this issue May 12, 2020 · 1 comment · Fixed by #139
Assignees
@larkox
Labels
Type/Bug Something isn't working
Milestone
v1.0.0

Comments

@DHaussermann
Copy link

The current settings panel uses 0 to indicate midnight or noon.
This confusing especially since we have AM and PM as people never refer to noon as 0 hours.
We should make this a 12.

0-Hour
@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels May 12, 2020
@larkox
Copy link
Contributor

larkox commented May 12, 2020

If I remember correctly, I did it so 0 is midnight, and 12 is noon (if you change from 0:45AM to 0:45PM it will be updated to 12:45PM).
Is this not working? Or would you prefer to see the 12 as another option when selecting AM times?

@hanzei hanzei removed the Triage label May 12, 2020
@mickmister mickmister added this to the 0.1.0 milestone May 19, 2020
@larkox larkox mentioned this issue May 20, 2020
Merged
mickmister pushed a commit that referenced this issue May 26, 2020
@larkox
[GH-127] Replace the 0 with 12 to indicate noon and midnight (#139)
14ae3b8
ayusht2810 pushed a commit that referenced this issue Feb 16, 2024
@lieut-data @mickmister @ayusht2810
Sync with playbooks: install-go-tools, gotestsum, and dynamic versions (
7d60f3a 
#192)

* Revert "Update main.go (#154)"

This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475.

* Revert "[MM-33506] Use embed package to include plugin manifest (#145)"

This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f.

* Revert "Don't generate manifest.ts (#127)"

This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e.

* install-go-tools target, adopt gotestsum

* bring back make apply + automatic versioning

* Update build/manifest/main.go

Co-authored-by: Michael Kochell <[email protected]>

* suppress git describe error when no tags match

* make version/release notes opt-in

* fix whitespace in Makefile

* document version management options

---------

Co-authored-by: Michael Kochell <[email protected]>
wiggin77 pushed a commit that referenced this issue Jul 4, 2024
@ayusht2810 @lieut-data
@mickmister @hanzei @Kshitij-Katiyar
[MM-231] Sync the plugin with starter template (#356)
88a1729 
* Sync with playbooks: install-go-tools, gotestsum, and dynamic versions (#192)

* Revert "Update main.go (#154)"

This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475.

* Revert "[MM-33506] Use embed package to include plugin manifest (#145)"

This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f.

* Revert "Don't generate manifest.ts (#127)"

This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e.

* install-go-tools target, adopt gotestsum

* bring back make apply + automatic versioning

* Update build/manifest/main.go

Co-authored-by: Michael Kochell <[email protected]>

* suppress git describe error when no tags match

* make version/release notes opt-in

* fix whitespace in Makefile

* document version management options

---------

Co-authored-by: Michael Kochell <[email protected]>

* Fetch plugin logs from server (#193)

Co-authored-by: Jesse Hallam <[email protected]>

* [MM-231]: Fixed merge conflicts

* [MM-231] Fix flaky tests

---------

Co-authored-by: Jesse Hallam <[email protected]>
Co-authored-by: Michael Kochell <[email protected]>
Co-authored-by: Ben Schumacher <[email protected]>
Co-authored-by: kshitij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larkox larkox

Labels
Type/Bug Something isn't working
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

[GH-127] Replace the 0 with 12 to indicate noon and midnight larkox/mattermost-plugin-mscalendar
4 participants
@larkox @mickmister @hanzei @DHaussermann