[GH-500]: Fixed github issue "Emoji synchronisation for PR/issue on github" #632

Kshitij-Katiyar · 2023-01-17T11:54:55Z

Summary

When the GitHub bot creates a post, it's always related to some specific issue/PR or comment. This PR has added the functionality that if a user reacts to the post in Mattermost with one of the 8 emojis supported for reactions on GitHub, the plugin will proxy this reaction to the appropriate PR/comment on GitHub. Likewise, if the user removes their emoji reaction in Mattermost, it will remove it in GitHub. The supported event notifications are:-
Issue/PR creations
Issue/PR comments
PR review comments
This PR is an extension of PR #575
Issue #500

…#17) * test * Feat for adding reactions to comments * Fix checkstyle * revert readme * revert * [MI-2597]:Fixed github issue mattermost#500 for emoji synchronisation * [MI-2597]:Fixed review comments * [MI-2597]:Fixed review comments * [MI-2597]:Fixed review comments Co-authored-by: LokeshN <[email protected]>

mattermost-build · 2023-01-17T11:55:04Z

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

server/plugin/plugin.go

javaguirre · 2023-01-30T10:41:59Z

Thank you for the work @Kshitij-Katiyar ! Let me know what you think.

hanzei

Nice work 👍

server/plugin/plugin.go

hanzei · 2023-02-02T13:43:08Z

server/plugin/plugin.go

+	post, err := p.client.Post.GetPost(reaction.PostId)
+	if err != nil {
+		p.API.LogDebug("Error fetching post for reaction", "error", err.Error())
+		return orgRepo, id, objectType, false
+	}


This is costly. For most of the reactions posted, an RPC request is made to fetch the post. It's a bummer ReactionHasBeenAdded doesn't provide the post.

Anyway, I don't see a way to get around the RPC call without changing the hook.

server/plugin/plugin.go

…n github plugin (#19) * [MI-2688]:Fixed review comments by mm team for issue mattermost#500 on github plugin * [MI-2688]:Fixed review comments * [MI-2688]:Fixed review comments

mattermost-build · 2023-02-17T01:01:36Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

hanzei · 2023-02-20T13:24:41Z

@DHaussermann Gentle reminder to review the PR

hanzei · 2023-02-21T18:38:54Z

/update-branch

mattermost-build · 2023-02-21T18:38:56Z

We don't have permissions to update this PR, please contact the submitter to apply the update.

…ub into MM-500

…hub into MM-500

Kshitij-Katiyar · 2023-02-22T06:23:00Z

@hanzei synced with master

DHaussermann · 2023-02-23T06:11:40Z

Thanks @Kshitij-Katiyar
For the supported reactions:

User reactions in MM will add in GitHub
User removing from MM will remove the reaction
Users not mapped to a GitHub account have no affect (as expected as there would be no user to attribute the reaction to)
User reacting in GitHub has no effect on MM post (as expected)
Tested on Issue/PR creations and Issue/PR comments

Note I'm having an issue making the pull_reviews feature work but it's just something that's not clear about the subscriptions in general. I'm fine confirming this post merge.

LGTM!

codecov-commenter · 2023-02-23T10:19:39Z

Codecov Report

Base: 15.63% // Head: 15.53% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (f40c7bb) compared to base (9f37670).
Patch coverage: 12.28% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
- Coverage   15.63%   15.53%   -0.11%     
==========================================
  Files          15       15              
  Lines        5243     5414     +171     
==========================================
+ Hits          820      841      +21     
- Misses       4380     4530     +150     
  Partials       43       43

Impacted Files	Coverage Δ
server/plugin/webhook.go	`0.83% <0.00%> (-0.03%)`	⬇️
server/plugin/plugin.go	`5.98% <14.68%> (+2.29%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mickmister · 2023-11-28T16:37:04Z

It looks like we don't take into account skin-tone emojis here. Maybe a good HW ticket to support this. More info here LokeshN#1 (comment)

Kshitij-Katiyar requested a review from hanzei as a code owner January 17, 2023 11:54

mattermost-build added the Contributor label Jan 17, 2023

Kshitij-Katiyar changed the title ~~[GH-500]: Fixed github issue mattermost#500 for emoji synchronisation~~ [GH-500]: Fixed github issue "Emoji synchronisation for PR/issue on github" Jan 17, 2023

hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 27, 2023

hanzei requested a review from javaguirre January 27, 2023 14:17

javaguirre suggested changes Jan 30, 2023

View reviewed changes

server/plugin/plugin.go Show resolved Hide resolved

server/plugin/plugin.go Outdated Show resolved Hide resolved

server/plugin/plugin.go Outdated Show resolved Hide resolved

server/plugin/plugin.go Show resolved Hide resolved

server/plugin/plugin.go Show resolved Hide resolved

Kshitij-Katiyar mentioned this pull request Jan 31, 2023

[MI-2688]:Fixed review comments by mm team for issue #500 on github plugin Brightscout/mattermost-plugin-github#19

Merged

hanzei linked an issue Feb 2, 2023 that may be closed by this pull request

Feature: Synchronize emoji reactions on posts generated by the plugin #500

Closed

hanzei approved these changes Feb 2, 2023

View reviewed changes

[MI-2688]:Fixed review comments by mm team for issue mattermost#500 o…

9d62309

…n github plugin (#19) * [MI-2688]:Fixed review comments by mm team for issue mattermost#500 on github plugin * [MI-2688]:Fixed review comments * [MI-2688]:Fixed review comments

Kshitij-Katiyar requested a review from javaguirre February 6, 2023 06:34

javaguirre approved these changes Feb 6, 2023

View reviewed changes

hanzei removed the 2: Dev Review Requires review by a core committer label Feb 6, 2023

hanzei requested a review from DHaussermann February 6, 2023 11:17

mattermost-build added the Lifecycle/1:stale label Feb 17, 2023

hanzei removed the Lifecycle/1:stale label Feb 20, 2023

hanzei added this to the v2.2.0 milestone Feb 20, 2023

Kshitij-Katiyar added 2 commits February 22, 2023 11:51

Merge branch 'master' of github.com:mattermost/mattermost-plugin-gith…

c33e224

…ub into MM-500

Merge branch 'MM-500' of github.com:Brightscout/mattermost-plugin-git…

f40c7bb

…hub into MM-500

DHaussermann removed the 3: QA Review Requires review by a QA tester label Feb 23, 2023

DHaussermann added the 4: Reviews Complete All reviewers have approved the pull request label Feb 23, 2023

hanzei merged commit 8d28b2e into mattermost:master Feb 23, 2023

mickmister mentioned this pull request Mar 20, 2023

Release bump v2.2.0 #583

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GH-500]: Fixed github issue "Emoji synchronisation for PR/issue on github" #632

[GH-500]: Fixed github issue "Emoji synchronisation for PR/issue on github" #632

Kshitij-Katiyar commented Jan 17, 2023 •

edited

Loading

mattermost-build commented Jan 17, 2023

javaguirre commented Jan 30, 2023

hanzei left a comment

hanzei Feb 2, 2023

mattermost-build commented Feb 17, 2023

hanzei commented Feb 20, 2023

hanzei commented Feb 21, 2023

mattermost-build commented Feb 21, 2023

Kshitij-Katiyar commented Feb 22, 2023

DHaussermann commented Feb 23, 2023 •

edited by hanzei

Loading

codecov-commenter commented Feb 23, 2023

mickmister commented Nov 28, 2023

[GH-500]: Fixed github issue "Emoji synchronisation for PR/issue on github" #632

[GH-500]: Fixed github issue "Emoji synchronisation for PR/issue on github" #632

Conversation

Kshitij-Katiyar commented Jan 17, 2023 • edited Loading

mattermost-build commented Jan 17, 2023

javaguirre commented Jan 30, 2023

hanzei left a comment

Choose a reason for hiding this comment

hanzei Feb 2, 2023

Choose a reason for hiding this comment

mattermost-build commented Feb 17, 2023

hanzei commented Feb 20, 2023

hanzei commented Feb 21, 2023

mattermost-build commented Feb 21, 2023

Kshitij-Katiyar commented Feb 22, 2023

DHaussermann commented Feb 23, 2023 • edited by hanzei Loading

codecov-commenter commented Feb 23, 2023

Codecov Report

mickmister commented Nov 28, 2023

Kshitij-Katiyar commented Jan 17, 2023 •

edited

Loading

DHaussermann commented Feb 23, 2023 •

edited by hanzei

Loading