Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Synchronize emoji reactions on posts generated by the plugin #500

Closed
mickmister opened this issue Oct 13, 2021 · 2 comments · Fixed by #632
Closed

Feature: Synchronize emoji reactions on posts generated by the plugin #500

mickmister opened this issue Oct 13, 2021 · 2 comments · Fixed by #632
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature

Comments

@mickmister
Copy link
Contributor

mickmister commented Oct 13, 2021 •
edited
Loading

When the GitHub bot creates a post, it's always related to some specific issue/PR or comment. If a user reacts to the post in Mattermost with one of the 8 emojis supported for reactions on GitHub, the plugin should proxy this reaction to the appropriate PR/comment on GitHub. Likewise, if the user removes their emoji reaction in Mattermost, we should remove it in GitHub.

We don't need to perform synchronization from GitHub to Mattermost. If someone reacts to a PR/comment on GitHub, the plugin doesn't need to propagate that reaction to the associated post(s).

Going forward, we should store the (issue/PR or comment) URL in the post.props field for all posts made by the bot. This way, we can deterministically figure out which PR or comment is associated with this post.
@mickmister mickmister added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Hacktoberfest Tech/Go Difficulty/2:Medium Medium ticket Type/Enhancement New feature or improvement of existing feature labels Oct 13, 2021
@mickmister
Copy link
Contributor Author

https://developers.mattermost.com/integrate/plugins/server/reference/#Hooks.ReactionHasBeenAdded
https://developers.mattermost.com/integrate/plugins/server/reference/#Hooks.ReactionHasBeenRemoved

This was referenced Jul 31, 2022
Closed
Closed
@mickmister
Copy link
Contributor Author

Note that there is progress on this ticket in an abandoned PR LokeshN#1

Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Jan 13, 2023
@Kshitij-Katiyar
[MI-2597]:Fixed github issue mattermost#500 for emoji synchronisation
4ff669d
@Kshitij-Katiyar Kshitij-Katiyar mentioned this issue Jan 13, 2023
Merged
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Jan 17, 2023
@Kshitij-Katiyar @LokeshN
[MI-2597]:Fixed github issue mattermost#500 for emoji synchronisation (…
f147f36 
…#17)

* test

* Feat for adding reactions to comments

* Fix checkstyle

* revert readme

* revert

* [MI-2597]:Fixed github issue mattermost#500 for emoji synchronisation

* [MI-2597]:Fixed review comments

* [MI-2597]:Fixed review comments

* [MI-2597]:Fixed review comments

Co-authored-by: LokeshN <[email protected]>
@Kshitij-Katiyar Kshitij-Katiyar mentioned this issue Jan 17, 2023
Merged
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Jan 31, 2023
@Kshitij-Katiyar
[MI-2688]:Fixed review comments by mm team for issue mattermost#500 o…
e09ddff 
…n github plugin
@hanzei hanzei linked a pull request Feb 2, 2023 that will close this issue
[GH-500]: Fixed github issue "Emoji synchronisation for PR/issue on github" #632
Merged
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Feb 2, 2023
@hanzei hanzei moved this from Todo to Submitted in Brightscout Plugin Maintenance Feb 2, 2023
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Feb 6, 2023
@Kshitij-Katiyar
[MI-2688]:Fixed review comments by mm team for issue mattermost#500 o…
9d62309 
…n github plugin (#19)

* [MI-2688]:Fixed review comments by mm team for issue mattermost#500 on github plugin

* [MI-2688]:Fixed review comments

* [MI-2688]:Fixed review comments
hanzei pushed a commit that referenced this issue Feb 23, 2023
@Kshitij-Katiyar
[GH-500]: Fixed github issue "Emoji synchronisation for PR/issue on g…
8d28b2e 
…ithub" (#632)
@github-project-automation github-project-automation bot moved this from Submitted to Done in Brightscout Plugin Maintenance Feb 23, 2023
@avas27JTG avas27JTG mentioned this issue Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Projects
Brightscout Plugin Maintenance
Status: Done
Milestone
No milestone
2 participants
@mickmister @hanzei