Serve the profile image for the plugin from the plugin itself

[jwilander]

This is the long term fix for #46 but unfortunately it requires some changes within the Mattermost server to work properly. The issue is that the Mattermost client and server use an image proxy for profile pictures that rejects URLs using the localhost or the site URL for security reasons.

@hmhealey is going to bring this up with the Mattermost security team to discuss ways around this so that plugins can serve images used by the Mattermost clients.

Long term fixes #46

[hanzei]

he issue is that the Mattermost client and server use an image proxy for profile pictures that rejects URLs using the localhost or the site URL for security reasons.

Could you elaborate a bit? If you use $SITEURL/plugins/github/assets/profile.png this should work fine. This is how Matterpoll solves this problem.

The only problem is that this approach doesn't work if $SITEURL is localhost. See https://community.mattermost.com/core/pl/jwbhjkqyi7ny3cu9jh6zkr4sde for a discussion about this.

[jwilander]

Interesting, I was talking with @hmhealey and brought up doing that but he seemed to think that wouldn't work either. If it's working for Matterpoll then it should work here

[jwilander]

I will try doing that

[hanzei]

Please be aware of this bug: https://mattermost.atlassian.net/browse/MM-14314

You can find the Matterpoll code here.

[jwilander]

Updated to use the SiteURL instead of a relative URL and tested to confirm it works when the SiteURL is not localhost.

[cpanato]

/check-cla

[hanzei]

LTGM. 👍 One not blocking commend.