Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin user profile image is missing #46

Closed
tgly307 opened this issue Feb 19, 2019 · 3 comments · Fixed by #50
Closed

Plugin user profile image is missing #46

tgly307 opened this issue Feb 19, 2019 · 3 comments · Fixed by #50
Labels
Help Wanted Community help wanted

Comments

@tgly307
Copy link

tgly307 commented Feb 19, 2019

I have connect the plugin to github, but I found the user profile image can't load correct.
image
The image link is https://mattermost-server/api/v4/image?url=https%3A%2F%2Fassets-cdn.github.com%2Fimages%2Fmodules%2Flogos_page%2FGitHub-Mark.png, it return 403 error.
And I found GitHub-Mark.png is 404, can the plugin use my own profile image?
@jwilander
Copy link
Member

jwilander commented Feb 19, 2019 •
edited
Loading

Yes, seems like the image the plugin pointed to (a github hosted image) no longer exists. The proper solution is to include the image with the plugin and have it serve it through the REST API. I'm planning on updating the plugin in the next few days with the fix but if someone wants to work on it instead feel free

@jwilander jwilander added bug Help Wanted Community help wanted labels Feb 19, 2019
@hanzei
Copy link
Contributor

hanzei commented Feb 20, 2019

FYI there is currently a discussion about how plugins should handle static files: https://community-daily.mattermost.com/core/pl/qm9houtcx7rgtf9akeyci5htqr

@jwilander
Copy link
Member

I'm going to work on this now

This was referenced Feb 22, 2019
Merged
Merged
hanzei pushed a commit that referenced this issue Feb 22, 2019
@jwilander @hanzei
Temporarily update profile image to point to new external location (#51)
4114ae8 
Short term fix for #46 

For why this is needed see #50
IndushaS pushed a commit to IndushaS/mattermost-plugin-github that referenced this issue Feb 8, 2021
@jwilander
Bump version to 0.1.13 (mattermost#46)
d02516b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Community help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Serve the profile image for the plugin from the plugin itself mattermost/mattermost-plugin-github
3 participants
@jwilander @hanzei @tgly307