-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs on how to add new releases #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only thing that comes to my mind is that mattermod automated message after a version cut ask to run "make plugins.json", instead cmd add. Should that also be changed?
Good question @larkox. Given that sometime |
It would break the flow for those that just want to copy paste those lines, but yes, link to this documentation may be needed. I wonder whether a small explanation on the message (for those that have done it over and over but fail to remember the syntax) on the two options would be nice too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the additional instructions! I added some suggestions for wording organization.
@jfrerich @larkox After thinking a bit more about this PR, I don't consider supporting two ways of adding a release valuable any longer. Hence, I'm leaning toward deprecating |
Summary
generator add
should be used to add releases for all not predefined plugins. This PR updated the documentation to make this clear.Ticket Link
Fixes #74