Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release_notes_url #129

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Add release_notes_url #129

merged 3 commits into from
Sep 23, 2020

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Sep 23, 2020

Summary

Add release_notes_url

Ticket Link

Need because of mattermost/mattermost-marketplace#100

@hanzei hanzei requested a review from levb as a code owner September 23, 2020 00:41
@levb
Copy link
Contributor

levb commented Sep 23, 2020

image

@codecov-commenter
Copy link

Codecov Report

Merging #129 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   46.16%   45.04%   -1.12%     
==========================================
  Files           6        6              
  Lines         600      535      -65     
==========================================
- Hits          277      241      -36     
+ Misses        306      278      -28     
+ Partials       17       16       -1     
Impacted Files Coverage Δ
server/autolinkclient/client.go 66.66% <0.00%> (-5.34%) ⬇️
server/autolinkplugin/config.go 70.49% <0.00%> (-3.12%) ⬇️
server/api/api.go 61.29% <0.00%> (-1.95%) ⬇️
server/autolinkplugin/plugin.go 91.07% <0.00%> (-0.93%) ⬇️
server/autolinkplugin/command.go 0.00% <0.00%> (ø)
server/autolink/autolink.go 51.16% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db182b...1c6f240. Read the comment docs.

@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Sep 23, 2020
@hanzei hanzei added this to the v1.3.0 milestone Sep 23, 2020
@hanzei hanzei merged commit 8acad23 into master Sep 23, 2020
@hanzei hanzei deleted the release_notes_url branch September 23, 2020 01:12
@hanzei hanzei mentioned this pull request Apr 15, 2021
2 tasks
@hanzei hanzei modified the milestones: v1.3.0, v1.2.2 Apr 15, 2021
hanzei added a commit that referenced this pull request Apr 15, 2021
hanzei added a commit that referenced this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants