Hide on autostart #230

razzeee · 2016-08-02T19:31:30Z

This should hopefully address #228
Untested so far, will grab the artifacts from ci, as soon as they are up and test those.

Let's hope Teamwork/node-auto-launch#31 is solved.

razzeee · 2016-08-02T20:25:55Z

Doesn't seem to work for me on windows 10.
Can other platforms please try?
https://circleci.com/gh/mattermost/desktop/539#artifacts

razzeee · 2016-08-03T06:28:16Z

Also doesn't work on win7

jasonblais · 2016-08-03T13:11:53Z

Any help from the community here?

@razzeee Teamwork/node-auto-launch#31 seems to reference isHidden function. Would that be of any use?

razzeee · 2016-08-03T17:22:50Z

That's what we're trying to use. I'm just not sure if our exe understands --hidden or if they have a bug not even setting that

jasonblais · 2016-08-08T04:41:23Z

@yuya-oc Would you have any thoughts?

yuya-oc · 2016-08-08T16:00:54Z

Not applicable for OS X. In my thoughts, apps should handle --hidden flag because electron doesn't understand it, too.

razzeee · 2016-08-08T17:47:43Z

Well the mac implementation isn't trying to use --hidden
https://github.com/Teamwork/node-auto-launch/blob/master/src/AutoLaunchMac.coffee

yuya-oc · 2016-08-09T12:33:10Z

src/main.js

    var appLauncher = new AutoLaunch({
-      name: 'Mattermost'
+      name: 'Mattermost',
+      isHidden: true


I misunderstood the changelog. This part is called when uninstalling the application. So you should use isHidden in settings.jsx which enables auto-start. Then, possibly main.js have to handle the --hidden flag.

razzeee · 2016-08-09T15:20:23Z

Changed and now it's writing the registry key correctly. But it's like you said, electron doesn't understand --hidden for windows

jasonblais · 2016-08-12T03:18:20Z

Any thoughts from the community here?

razzeee · 2016-08-12T09:44:47Z

Would be nice to know if this implementation works on osx and Linux. Then we just need to figure out why windows doesn't.

yuya-oc · 2016-08-13T02:13:22Z

Not need to test on OS X because auto-start is not implemented. Please see #164.

jasonblais · 2016-08-14T00:35:59Z

I see, thanks @yuya-oc ,

@timroes @jnugh Would love to have your help checking if the desktop app stays minimized after autostart when logging in to a Linux machine.

If either of you would like to try, you can download an artifact here: https://circleci.com/gh/mattermost/desktop/539#artifacts

timroes · 2016-08-14T08:43:28Z

Doesn't seem to work on my system (Arch x64, pretty custom window manager - so perhaps someone with a regular Desktop Environment should test).

But looking at the generated desktop file:

[Desktop Entry]
Type=Application
Vestion=1.0
Name=Mattermost
Comment=Mattermost startup script
Exec=/home/timroes/apps/mattermost-desktop-linux-x64/Mattermost
StartupNotify=false
Terminal=false

and looking at the source code of auto-launch when setting isHidden there should actually be the --hidden flag in the end of the Exec command, which isn't in my case.

So there might be some problems with the generation of this desktop file. Also I tried starting the above mattermost with --hidden directly which doesn't cause it to be hidden on my system either.

Could you point me to the source parts, where --hidden is read in mattermost and done somethign appropriate?

razzeee · 2016-08-14T10:20:33Z

I thought the hidden would be handled by electron packager as that's responsible for building the executeables etc. But it seems like it doesn't or is not responsible for the handling.

jnugh · 2016-08-14T12:58:45Z

Does not work for me (Unity).

auto-launch generates a desktop file in ~/.config/autostart which should contains the --hidden param. When the default desktop file, which is being generated by electron-(builder/packager?), contains the hidden flag, the app would start minimized even if it wasn't auto started.

timroes · 2016-08-14T13:02:38Z

Yeah. It should :-)

But apparently for me the hidden isn't in the generated desktop file. If the electron wrapper doesn't handle the hidden flag, and you don't do it, that might some the mystery why it isn't working.

jnugh · 2016-08-14T15:04:39Z

https://github.com/Teamwork/node-auto-launch/blob/master/src/index.coffee#L14
isHidden is actually mapped to isHiddenOnLaunch.

When running this directly from your branch, without using the artifacts, things work like expected. auto-launch 3.0 is out now. maybe it's been fixed already?

razzeee · 2016-08-16T17:24:33Z

Version 3.0 got rid of the ES6-Promise dependency, not sure how to fix that for us and get it building again. Changelog doesn't seem to involve a fix for our problem.

jasonblais · 2016-09-04T17:43:43Z

Adding a pending label until Teamwork/node-auto-launch#39 is merged

razzeee · 2016-09-04T21:18:25Z

@timroes @jnugh
Would be nice to know if it already works for linux like this: https://circleci.com/gh/mattermost/desktop/649#artifacts

jnugh · 2016-09-05T07:10:23Z

Minimized autostart works for me :)

timroes · 2016-09-05T07:14:03Z

@razzeee works for me too (custom window manager, Archlinux x64), but brings me back to another problem, which I will open another ticket for (skip taskbar hints).

Closes mattermost#228

razzeee · 2016-09-12T20:08:11Z

Upstream just merged and release Teamwork/node-auto-launch#39
I've updated this PR to include it, so maybe we can still make it into 1.4 🚀

Let's wait for the artifacts

jasonblais · 2016-09-13T05:03:08Z

Awesome! I tried looking for the artifacts earlier today in CircleCI but couldn't find them..

@yuya-oc are they located elsewhere?

Added for v1.4 so we can speed up the testing.

razzeee · 2016-09-13T05:51:47Z

https://circleci.com/gh/Razzeee/desktop/17#artifacts

jasonblais · 2016-09-13T12:33:19Z

Thanks!

Just tested (Windows 10, 64-bit) and it didn't auto-start for me when I restarted my machine.

I have Start app on login. checked.

yuya-oc · 2016-09-13T12:48:47Z

I have tested .zip and setup.exe on Windows 10 64-bit, and .deb on Ubuntu 14.04 64-bit. They are working well.

@jasonblais Would you check again?

jasonblais · 2016-09-13T12:52:47Z

Hmm okay, maybe the issue was on my end.

jasonblais · 2016-09-13T14:29:49Z

Tested; works on Windows 10 after disabling and re-enabling the start app on login setting.

@yuya-oc helped troubleshoot and likely related to me running a v1.3 version where auto-start might have been disabled.

The setting is not overwritten unless you disable and re-enable it in the settings UI (if you simply click 'Save' on the settings page without a change, the option will remain to what it was before in the registry). Investigating whether an easy fix for v1.4/3.4 or if we leave it for the next version.

For this particular PR however, we're good to go. Thanks everyone!

yuya-oc · 2016-09-13T16:03:53Z

So I will change the behavior when saving options in settings. It would always update the registry info. Thanks!

razzeee · 2016-09-13T16:09:56Z

Please do that in a pr and give me some heads up, as I have some problems
with other apps that work like that. Due to macaffee doing stupid stuff.

On Tue, Sep 13, 2016, 18:03 Yuya Ochiai [email protected] wrote:

So I will change the behavior when saving options in settings. It would
always update the registry info. Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#230 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFqyZKVpOO8DsRNwW3Z9YzdgFGq9hRGAks5qpslrgaJpZM4Ja9x5
.

yuya-oc · 2016-09-13T16:15:49Z

@razzeee I created new PR #283. Would you write about the problem you met in detail?

jasonblais · 2016-09-13T16:24:27Z

Thanks @razzeee, agree that this will need some careful testing. Let's take it in the next release.

Thanks @yuya-oc for the pull request! We'll test it out

razzeee force-pushed the hide-autostart branch from 2d40566 to 0c7eb24 Compare August 2, 2016 20:02

jasonblais added MacOS (looking for testers) Linux (looking for testers) labels Aug 2, 2016

yuya-oc removed the MacOS (looking for testers) label Aug 8, 2016

yuya-oc reviewed Aug 9, 2016
View reviewed changes

razzeee force-pushed the hide-autostart branch from 357e152 to 99ef9c2 Compare August 9, 2016 14:45

razzeee force-pushed the hide-autostart branch from 99ef9c2 to d4efee6 Compare August 14, 2016 19:37

jasonblais added this to the v1.4.0 milestone Aug 16, 2016

razzeee force-pushed the hide-autostart branch 2 times, most recently from 563bcc3 to ef76628 Compare August 16, 2016 08:34

jasonblais added Help Wanted and removed Linux (looking for testers) labels Aug 19, 2016

yuya-oc removed the Help Wanted label Aug 29, 2016

jasonblais added Linux Pending and removed Linux (looking for testers) labels Sep 4, 2016

jasonblais removed this from the v1.4.0 milestone Sep 4, 2016

Hide on autostart

bc154f5

Closes mattermost#228

razzeee force-pushed the hide-autostart branch from db78920 to bc154f5 Compare September 12, 2016 20:06

jasonblais added this to the v1.4.0 milestone Sep 13, 2016

yuya-oc added Windows (looking for testers) and removed Pending labels Sep 13, 2016

jasonblais removed the Windows (looking for testers) label Sep 13, 2016

yuya-oc merged commit 7cfde1e into mattermost:master Sep 13, 2016

yuya-oc mentioned this pull request Sep 13, 2016

Save autostart settings always when saving options #283

Closed

gberdzenishvili mentioned this pull request Aug 8, 2017

The app is not minimized when "Start app on login" is enabled #570

Closed

3 tasks

yuya-oc mentioned this pull request Apr 2, 2018

Mattermost app is in Windows tab list after hidden auto-start #738

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide on autostart #230

Hide on autostart #230

razzeee commented Aug 2, 2016

razzeee commented Aug 2, 2016

razzeee commented Aug 3, 2016

jasonblais commented Aug 3, 2016

razzeee commented Aug 3, 2016

jasonblais commented Aug 8, 2016

yuya-oc commented Aug 8, 2016

razzeee commented Aug 8, 2016

yuya-oc Aug 9, 2016 •

edited

Loading

razzeee commented Aug 9, 2016

jasonblais commented Aug 12, 2016

razzeee commented Aug 12, 2016

yuya-oc commented Aug 13, 2016

jasonblais commented Aug 14, 2016

timroes commented Aug 14, 2016

razzeee commented Aug 14, 2016

jnugh commented Aug 14, 2016

timroes commented Aug 14, 2016

jnugh commented Aug 14, 2016 •

edited

Loading

razzeee commented Aug 16, 2016

jasonblais commented Sep 4, 2016

razzeee commented Sep 4, 2016

jnugh commented Sep 5, 2016

timroes commented Sep 5, 2016

razzeee commented Sep 12, 2016

jasonblais commented Sep 13, 2016

razzeee commented Sep 13, 2016

jasonblais commented Sep 13, 2016

yuya-oc commented Sep 13, 2016

jasonblais commented Sep 13, 2016

jasonblais commented Sep 13, 2016

yuya-oc commented Sep 13, 2016

razzeee commented Sep 13, 2016

yuya-oc commented Sep 13, 2016

jasonblais commented Sep 13, 2016

Hide on autostart #230

Hide on autostart #230

Conversation

razzeee commented Aug 2, 2016

razzeee commented Aug 2, 2016

razzeee commented Aug 3, 2016

jasonblais commented Aug 3, 2016

razzeee commented Aug 3, 2016

jasonblais commented Aug 8, 2016

yuya-oc commented Aug 8, 2016

razzeee commented Aug 8, 2016

yuya-oc Aug 9, 2016 • edited Loading

Choose a reason for hiding this comment

razzeee commented Aug 9, 2016

jasonblais commented Aug 12, 2016

razzeee commented Aug 12, 2016

yuya-oc commented Aug 13, 2016

jasonblais commented Aug 14, 2016

timroes commented Aug 14, 2016

razzeee commented Aug 14, 2016

jnugh commented Aug 14, 2016

timroes commented Aug 14, 2016

jnugh commented Aug 14, 2016 • edited Loading

razzeee commented Aug 16, 2016

jasonblais commented Sep 4, 2016

razzeee commented Sep 4, 2016

jnugh commented Sep 5, 2016

timroes commented Sep 5, 2016

razzeee commented Sep 12, 2016

jasonblais commented Sep 13, 2016

razzeee commented Sep 13, 2016

jasonblais commented Sep 13, 2016

yuya-oc commented Sep 13, 2016

jasonblais commented Sep 13, 2016

jasonblais commented Sep 13, 2016

yuya-oc commented Sep 13, 2016

razzeee commented Sep 13, 2016

yuya-oc commented Sep 13, 2016

jasonblais commented Sep 13, 2016

yuya-oc Aug 9, 2016 •

edited

Loading

jnugh commented Aug 14, 2016 •

edited

Loading